fix(flow-chat): keep streaming code preview tail visible#1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodePreviewtail sizing when nested auto-scroll is disabled so the rendered tail fits the preview viewport.autoScrollToBottomand keep completed previews rendering full content.Details
CodePreviewnow derives the streaming tail line limit from the preview height and only includes overscan when the preview is allowed to auto-scroll internally. For compact Write/Edit streaming previews, the latest generated code lines remain inside the nested viewport without requiring per-updatescrollTopwrites.The tradeoff is limited to the disabled nested auto-scroll path: compact streaming previews show slightly less tail context while content is still streaming. Completed previews continue to render the full content or full diff.
Verification
pnpm --dir src/web-ui run test:run -- src/flow_chat/components/CodePreview.test.tsx src/flow_chat/tool-cards/FileOperationToolCard.test.tsxpnpm run type-check:webpnpm run lint:webpnpm run check:repo-hygienegit diff --check