feat: Composer-Support für theme/private inkl. Core-replace-Strategie#46
Open
skerbis wants to merge 2 commits into
Open
feat: Composer-Support für theme/private inkl. Core-replace-Strategie#46skerbis wants to merge 2 commits into
skerbis wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Dieses PR erweitert das Theme-Addon um einen Composer-Workflow im Projektordner theme/private, inkl. automatischem Einbinden der Composer-Autoload-Datei und einer Installer-Startvorlage.
Changes:
- Boot-Phase lädt optional
theme/private/vendor/autoload.php. - Neue Pfad-Helper
theme_path::vendor()undtheme_path::composerAutoload(). - Installer legt
theme/private/vendoran und kopiert einetheme/private/composer.json-Vorlage (inkl.replace-Strategie); dazu Doku/Changelog und Versionsbump.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Dokumentiert Composer-Nutzung im Theme-Ordner und neue Path-Methoden |
| package.yml | Version auf 1.5.0 erhöht |
| lib/theme_path.php | Neue Pfadmethoden für vendor/ und Autoload-Pfad |
| lib/pages/theme_page_settings.php | Installer erzeugt private/vendor und legt private/composer.json-Vorlage an |
| install/composer.json | Composer-Startvorlage inkl. replace-Block und PSR-4-Autoload |
| CHANGELOG.md | Neuer Changelog-Eintrag für 1.5.0 |
| boot.php | Optionales include_once des Composer-Autoloaders in der Boot-Phase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Danke @skerbis <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zusammenfassung
Dieses PR erweitert das Theme-Addon um einen praxistauglichen Composer-Workflow im Projekt-Theme-Ordner
theme/private.Änderungen
theme/private/vendor/autoload.phpin der Boot-Phasetheme_path::vendor()theme_path::composerAutoload()theme/private/vendorantheme/private/composer.jsonals Startvorlagereplace-Einträge für zentrale REDAXO-Core-LibrariesMotivation
Projektabhängigkeiten können damit sauber im Theme-Ordner verwaltet werden, ohne Core-Libraries erneut aufzulösen oder zu installieren.
Validierung
composer update --lockfürtheme/privateohne Konfliktenette/utilserfolgreich