Skip to content

[Share By Email] Load translations on configuration page#492

Merged
Alkarex merged 1 commit into
FreshRSS:mainfrom
JamBalaya56562:fix/share-by-email-config-translations
Jul 12, 2026
Merged

[Share By Email] Load translations on configuration page#492
Alkarex merged 1 commit into
FreshRSS:mainfrom
JamBalaya56562:fix/share-by-email-config-translations

Conversation

@JamBalaya56562

Copy link
Copy Markdown
Contributor

Summary

  • register Share By Email translations when FreshRSS opens the extension configuration page
  • keep the existing translation registration during normal extension initialization
  • bump the extension version to 0.3.6

Fixes #390

Root cause

FreshRSS invokes handleConfigureAction() when rendering an extension's configuration page. Share By Email only registered its translations from init(), so the configuration template could render before the extension translation namespace was available and expose keys such as shareByEmail.share.manage.mailer.

Visual comparison

Both screenshots use FreshRSS 1.29.2-dev, the Origine light theme, English UI, and a 1280×720 viewport.

Before After
Before: untranslated Share By Email configuration keys After: translated Share By Email configuration labels

Validation

  • confirmed the configuration GET renders Mailing system, the active mailer, and the translated help text
  • confirmed normal extension initialization still registers translations for sharing and feedback messages
  • npm run eslint
  • npx stylelint "**/*.css"
  • npm run markdownlint

@JamBalaya56562 JamBalaya56562 force-pushed the fix/share-by-email-config-translations branch from f8d516f to 7e2e756 Compare July 12, 2026 03:11
@Alkarex Alkarex merged commit 556deed into FreshRSS:main Jul 12, 2026
1 check passed
@JamBalaya56562 JamBalaya56562 deleted the fix/share-by-email-config-translations branch July 12, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Share By Mail] Extension Config without translated labels

2 participants