[Share By Email] Load translations on configuration page#492
Merged
Alkarex merged 1 commit intoJul 12, 2026
Merged
Conversation
f8d516f to
7e2e756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #390
Root cause
FreshRSS invokes
handleConfigureAction()when rendering an extension's configuration page. Share By Email only registered its translations frominit(), so the configuration template could render before the extension translation namespace was available and expose keys such asshareByEmail.share.manage.mailer.Visual comparison
Both screenshots use FreshRSS 1.29.2-dev, the Origine light theme, English UI, and a 1280×720 viewport.
Validation
Mailing system, the active mailer, and the translated help textnpm run eslintnpx stylelint "**/*.css"npm run markdownlint