Skip to content

Fix compliance findings in Frends.Edifact.ConvertToXml - #16

Draft
MichalFrends1 with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-compliance-findings-edifact
Draft

Fix compliance findings in Frends.Edifact.ConvertToXml#16
MichalFrends1 with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-compliance-findings-edifact

Conversation

Copilot AI commented Aug 24, 2026

Copy link
Copy Markdown

Resolves 5 analyzer findings (FT0007 ×2, FT0011 ×2, FT0012 ×1) and upgrades target framework from net6.0 to net8.0.

Breaking change — version bumped to 2.0.0.

Changes

  • Target framework: net6.0net8.0 (both task and test projects)
  • Method signature: Added required Options and CancellationToken parameters to ConvertToXml
  • Result class: Added Success and Error properties
  • Documentation: Added [Documentation(...)] attribute to task method
  • Error handling: Added ErrorHandler + ValidationHandler helpers; all exceptions route through exception.Handle(options)
  • Analyzers: Added StyleCop.Analyzers and FrendsTaskAnalyzers package references
  • Tests: Updated existing tests for new signature; added ErrorHandlerTest class

New method signature

[Documentation("https://tasks.frends.com/tasks/frends-tasks/Frends.Edifact.ConvertToXml")]
public static Result ConvertToXml(
    [PropertyTab] Input input,
    [PropertyTab] Options options,
    CancellationToken cancellationToken)

Note

Build cannot be verified locally — depends on private NuGet packages (Frends.Edifabric.*) only available in CI.

Copilot AI and others added 2 commits August 24, 2026 06:57
…oken params, add Success/Error properties, add Documentation link, add ErrorHandler/ValidationHandler, add analyzers

Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
…est assertion

Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix compliance findings in Frends.Edifact.ConvertToXml Fix compliance findings in Frends.Edifact.ConvertToXml Aug 24, 2026
Copilot AI requested a review from MichalFrends1 August 24, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants