Fix compliance findings in Frends.Edifact.ConvertToXml - #16
Draft
MichalFrends1 with Copilot wants to merge 4 commits into
Draft
Fix compliance findings in Frends.Edifact.ConvertToXml#16MichalFrends1 with Copilot wants to merge 4 commits into
MichalFrends1 with Copilot wants to merge 4 commits into
Conversation
…oken params, add Success/Error properties, add Documentation link, add ErrorHandler/ValidationHandler, add analyzers Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
…est assertion Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compliance findings in Frends.Edifact.ConvertToXml
Fix compliance findings in Frends.Edifact.ConvertToXml
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 5 analyzer findings (FT0007 ×2, FT0011 ×2, FT0012 ×1) and upgrades target framework from net6.0 to net8.0.
Breaking change — version bumped to 2.0.0.
Changes
net6.0→net8.0(both task and test projects)OptionsandCancellationTokenparameters toConvertToXmlSuccessandErrorproperties[Documentation(...)]attribute to task methodErrorHandler+ValidationHandlerhelpers; all exceptions route throughexception.Handle(options)StyleCop.AnalyzersandFrendsTaskAnalyzerspackage referencesErrorHandlerTestclassNew method signature
Note
Build cannot be verified locally — depends on private NuGet packages (
Frends.Edifabric.*) only available in CI.