Fix compliance findings in Frends.ServiceBus.Read - #16
Open
MichalFrends1 with Copilot wants to merge 6 commits into
Open
Fix compliance findings in Frends.ServiceBus.Read#16MichalFrends1 with Copilot wants to merge 6 commits into
MichalFrends1 with Copilot wants to merge 6 commits into
Conversation
… add error handling, add Success/Error to Result, add ThrowErrorOnFailure/ErrorMessageOnFailure to Options, add example tags, add analyzers Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compliance findings in Frends.ServiceBus.Read
Fix compliance findings in Frends.ServiceBus.Read
Aug 20, 2026
…onHandler Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
MichalFrends1
marked this pull request as ready for review
August 24, 2026 06:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 6 analyzer findings (FT0011, FT0014, FT0015) and upgrades target framework from
net6.0tonet8.0.Breaking changes (version → 2.1.0)
Success(bool) andErrorproperties per FT0011. ExistingResultslist property preserved.Errorclass (Message,AdditionalInfo) added toDefinitions/.Error handling
Optionsgains requiredThrowErrorOnFailureandErrorMessageOnFailureproperties (FT0015), defaulting totrueand""respectively.ErrorHandlerandValidationHandleradded toHelpers/, matching the platform-standard pattern.Read()body wrapped in try/catch delegating toex.Handle(options):Analyzer / framework setup
net8.0(both main and test projects)StyleCop.Analyzers,FrendsTaskAnalyzerspackage referencesGlobalSuppressions.csandAdditionalFilesforFrendsTaskMetadata.json<example>XML doc tags onMessagingFactory.InstanceandResult.Results(FT0014)Tests
ErrorHandlerTests.cs: 3 MSTest cases covering throw-on-failure, return-failed-result, and custom error message scenarios using an invalid connection string to trigger failures.