Skip to content

Fix compliance findings in Frends.ServiceBus.Read - #16

Open
MichalFrends1 with Copilot wants to merge 6 commits into
mainfrom
copilot/fix-compliance-findings
Open

Fix compliance findings in Frends.ServiceBus.Read#16
MichalFrends1 with Copilot wants to merge 6 commits into
mainfrom
copilot/fix-compliance-findings

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown

Resolves 6 analyzer findings (FT0011, FT0014, FT0015) and upgrades target framework from net6.0 to net8.0.

Breaking changes (version → 2.1.0)

  • Result class now includes Success (bool) and Error properties per FT0011. Existing Results list property preserved.
  • New Error class (Message, AdditionalInfo) added to Definitions/.

Error handling

  • Options gains required ThrowErrorOnFailure and ErrorMessageOnFailure properties (FT0015), defaulting to true and "" respectively.
  • ErrorHandler and ValidationHandler added to Helpers/, matching the platform-standard pattern.
  • Read() body wrapped in try/catch delegating to ex.Handle(options):
catch (Exception ex)
{
    return ex.Handle(options);
}

Analyzer / framework setup

  • Target framework → net8.0 (both main and test projects)
  • Added StyleCop.Analyzers, FrendsTaskAnalyzers package references
  • Added GlobalSuppressions.cs and AdditionalFiles for FrendsTaskMetadata.json
  • Added missing <example> XML doc tags on MessagingFactory.Instance and Result.Results (FT0014)

Tests

  • ErrorHandlerTests.cs: 3 MSTest cases covering throw-on-failure, return-failed-result, and custom error message scenarios using an invalid connection string to trigger failures.

… add error handling, add Success/Error to Result, add ThrowErrorOnFailure/ErrorMessageOnFailure to Options, add example tags, add analyzers

Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix compliance findings in Frends.ServiceBus.Read Fix compliance findings in Frends.ServiceBus.Read Aug 20, 2026
Copilot AI requested a review from MichalFrends1 August 20, 2026 06:33
…onHandler

Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
@MichalFrends1
MichalFrends1 marked this pull request as ready for review August 24, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants