Feature/drag drop improve - #9591
Conversation
github-actions
Bot
added
the
PR: waiting for review
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
|
ill leave it up to you if you would like to change anything #9469 (comment) |
|
Made some updates see #9469 (comment) |
|
Im wondering if we're sacrificing too much area for touch devices |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@Shadorc @caetano-dev do you have any opinions on this? Reading discussion in issue provides some more context |
|
I've tested with several desktop and mobile resolutions, it seems fine like this, better than previously |
|
@Shadorc Edit: disregard, we will review this PR in its current state and other styling related suggestions can be done in followups |
github-actions
Bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
* development: (165 commits) Translated using Weblate (Czech) Translated using Weblate (German) Hoist some v-ifs and use v-else and v-else-if (FreeTubeApp#9768) Translated using Weblate (Azerbaijani) Translated using Weblate (Hungarian) Translated using Weblate (Italian) Make SabrSchemePlugin more robust (FreeTubeApp#9753) Fix: tooltip not being aligned with dropdown arrow (FreeTubeApp#9714) Translated using Weblate (Breton) Translated using Weblate (Chinese (Simplified Han script)) fix: opening invalid playlist does not update the window title (FreeTubeApp#9765) Display different message when comments are turned off (FreeTubeApp#9752) ! Fix null handling (FreeTubeApp#9769) fix: do not try to parse grid video with null id (FreeTubeApp#9762) Added translation using Weblate (Thai) Translated using Weblate (Italian) Translated using Weblate (Czech) Translated using Weblate (Estonian) Translated using Weblate (Portuguese (Brazil)) Enable Azerbaijani Language (FreeTubeApp#9757) ... # Conflicts: # src/renderer/views/Playlist/Playlist.vue
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
PikachuEXE
added
the
PR: waiting for review
3 participants
Pull Request Type
Related issue
DnD: #8681
#9469 wants scrolling speed & drag zone size enlarged (There is also spacing between video rows but that doesn't make sense to me coz it looks fine when videos are watched)
Description
Screenshots
Grab bar style updated
List
Grid - Top
Grid - Bottom
Testing
Scroll speed: Ensure it's not too fast?
A. Grid Mode
B: List Mode
Same as (A)?
Desktop
Additional context
To see drag area size you can add following style to
src/renderer/components/AutoScrollWrapper/AutoScrollWrapper.css