Improve HighSeas validation and fix HighScore duplicate‑UUID logic - #148
Open
JaskRendix wants to merge 3 commits into
Open
Improve HighSeas validation and fix HighScore duplicate‑UUID logic#148JaskRendix wants to merge 3 commits into
JaskRendix wants to merge 3 commits into
Conversation
JaskRendix
force-pushed
the
HighSeasTest
branch
7 times, most recently
from
January 16, 2026 16:31
0077250 to
ebf301e
Compare
JaskRendix
force-pushed
the
HighSeasTest
branch
2 times, most recently
from
January 24, 2026 08:39
90bc476 to
dd0d05b
Compare
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
stiangre
reviewed
Aug 23, 2026
JaskRendix
force-pushed
the
HighSeasTest
branch
5 times, most recently
from
August 23, 2026 11:40
50984f7 to
0179f89
Compare
JaskRendix
force-pushed
the
HighSeasTest
branch
from
August 23, 2026 12:24
0179f89 to
6cf481f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HighScore
checkHighScoreto correctly detect duplicate game UUIDs and update an existing entry only when the new score is highertidyScoressorting and truncation bug by ensuring scores are explicitly sorted in descending order before applying.subList(NUMBER_OF_HIGH_SCORES, scores.size()).clear(), resolving issues where excess scores bypassed retention limitsTest Coverage Improvements
HighSeasTest,HighScoreTest,EuropeTestServerEuropeTestNext Steps / Post-Merge Todo:
Once this PR is merged, open a follow-up PR to clean up
src/net/sf/freecol/server/control/InGameController.javaby replacing this manual loop check:with the new helper method: