Skip to content

fix: make icon/folder rename dialog follow system light/dark theme #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiMoHo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make icon/folder rename dialog follow system light/dark theme #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Fixed unreadable dark-on-dark text in the icon/folder rename dialog when using light mode ([#198])

## [1.10.0] - 2026-02-14
### Added
Expand Down Expand Up @@ -130,6 +132,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#115]: https://github.com/FossifyOrg/Launcher/issues/115
[#170]: https://github.com/FossifyOrg/Launcher/issues/170
[#182]: https://github.com/FossifyOrg/Launcher/issues/182
[#198]: https://github.com/FossifyOrg/Launcher/issues/198
[#230]: https://github.com/FossifyOrg/Launcher/issues/230
[#234]: https://github.com/FossifyOrg/Launcher/issues/234
[#277]: https://github.com/FossifyOrg/Launcher/issues/277
Expand Down
14 changes: 13 additions & 1 deletion app/src/main/kotlin/org/fossify/home/dialogs/RenameItemDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package org.fossify.home.dialogs

import android.app.Activity
import android.app.AlertDialog
import android.view.ContextThemeWrapper
import com.google.android.material.dialog.MaterialAlertDialogBuilder
import org.fossify.commons.extensions.*
import org.fossify.commons.helpers.ensureBackgroundThread
import org.fossify.home.databinding.DialogRenameItemBinding
Expand All @@ -15,7 +17,17 @@ class RenameItemDialog(val activity: Activity, val item: HomeScreenGridItem, val
val view = binding.root
binding.renameItemEdittext.setText(item.title)

activity.getAlertDialogBuilder()
// MainActivity uses the forced-dark LauncherTheme so it can draw over the wallpaper.
// Building the Material dialog from that context keeps its surface dark even in light
// mode, producing dark text on a dark background. Wrap the context in the proper
// day/night theme so the dialog follows the system theme like the rest of the app.
val builder = if (activity.isDynamicTheme()) {
MaterialAlertDialogBuilder(ContextThemeWrapper(activity, activity.getThemeId()))
} else {
activity.getAlertDialogBuilder()
}

builder
.setPositiveButton(org.fossify.commons.R.string.ok, null)
.setNegativeButton(org.fossify.commons.R.string.cancel, null)
.apply {
Expand Down
Loading