Added alarm groups#473
Open
tristanlifn wants to merge 15 commits into
Open
Conversation
…s and added group model
…h translations from DeepL. Note: translations might be wrong, and multiple languages that have other translations have no translations because of missing support from DeepL
F/alarm groups
… in group, added page to rename group.
…e are more than zero groups. Removed hack fix for "getSelectedDaysString". Changed group toggle off when no alarms are on, not when all are on. changed commons version to 6.1.7 (see [PR FossifyOrg#365](FossifyOrg/commons#365))
…mporting backup. alarms get added to a group that does not exist
…roup_id` for reliable imports
Author
|
I want to add regarding failed tests. The detekt errors/warnings are not critical, i can still build and run it. Regarding the other build errors, they are from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
This feature addes groups to alarms.
Delete group. This will remove all the alarms from the group, not delete themNonegroup.Tests performed
Thrugh none of my testing have i noticed any performance changes.
Before & after preview
Before:

After:

Closes the following issue(s)
Sorry. i know that it says only work on accepted features. but i realy want this. hope its okay!
But this PR needs PR #365 in commons to be fixed before this will work, as it relies on that change.
Checklist
CHANGELOG.md(if applicable).Note. there was a problem with my git vonfig, so some of the commits says they were authored by "wit00", this is not the case and i have made all commits by myself