Skip to content

chore: re-export JSON config helpers - #759

Draft
ancheetah wants to merge 1 commit into
mainfrom
SDKS-5241-config-exports
Draft

chore: re-export JSON config helpers#759
ancheetah wants to merge 1 commit into
mainfrom
SDKS-5241-config-exports

Conversation

@ancheetah

Copy link
Copy Markdown
Collaborator

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-5241

Description

Re-export makeJourneyConfig, makeDavinciConfig, makeOidcConfig JSON helpers from respective client packages.

@changeset-bot

changeset-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 729c355

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@forgerock/davinci-client Minor
@forgerock/journey-client Minor
@forgerock/oidc-client Minor
@forgerock/device-client Minor
@forgerock/protect Minor
@forgerock/recognize Minor
@forgerock/sdk-types Minor
@forgerock/sdk-utilities Minor
@forgerock/iframe-manager Minor
@forgerock/sdk-logger Minor
@forgerock/sdk-oidc Minor
@forgerock/sdk-request-middleware Minor
@forgerock/storage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 729c355

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded <1s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded 4m 22s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-28 19:39:53 UTC

@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@759

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@759

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@759

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@759

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@759

@forgerock/recognize

pnpm add https://pkg.pr.new/@forgerock/recognize@759

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@759

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@759

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@759

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@759

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@759

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@759

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@759

commit: 729c355

@github-actions

Copy link
Copy Markdown
Contributor

Deployed fdeae60 to https://ForgeRock.github.io/ping-javascript-sdk/pr-759/fdeae6097580412addcf10c7eaae1b2efaecc76a branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/journey-client - 92.6 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)
🆕 @forgerock/device-client - 10.0 KB (new)
🆕 @forgerock/device-client - 0.0 KB (new)

📊 Minor Changes

📈 @forgerock/oidc-client - 35.5 KB (+0.1 KB)
📈 @forgerock/davinci-client - 59.7 KB (+0.1 KB)

➖ No Changes

@forgerock/sdk-utilities - 18.6 KB
@forgerock/recognize - 4284.4 KB
@forgerock/sdk-request-middleware - 4.6 KB
@forgerock/iframe-manager - 3.2 KB
@forgerock/sdk-oidc - 5.7 KB
@forgerock/storage - 1.5 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/sdk-types - 9.1 KB
@forgerock/protect - 144.6 KB


15 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.11%. Comparing base (eafe277) to head (729c355).
⚠️ Report is 112 commits behind head on main.

Files with missing lines Patch % Lines
packages/davinci-client/src/index.ts 0.00% 1 Missing ⚠️
packages/oidc-client/src/index.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (24.11%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   18.07%   24.11%   +6.03%     
==========================================
  Files         155      163       +8     
  Lines       24398    25796    +1398     
  Branches     1203     1687     +484     
==========================================
+ Hits         4410     6220    +1810     
+ Misses      19988    19576     -412     
Files with missing lines Coverage Δ
packages/journey-client/src/index.ts 100.00% <100.00%> (+75.00%) ⬆️
packages/davinci-client/src/index.ts 20.00% <0.00%> (-13.34%) ⬇️
packages/oidc-client/src/index.ts 25.00% <0.00%> (-25.00%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants