fix(deps): update dependency @forgerock/javascript-sdk to v4.9.0#617
fix(deps): update dependency @forgerock/javascript-sdk to v4.9.0#617renovate[bot] wants to merge 1 commit intomainfrom
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 9e597b9
☁️ Nx Cloud last updated this comment at |
9e597b9 to
04ecabc
Compare
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We removed the page.waitForResponse() check for the /signoff 302 response to fix the timeout caused by the @forgerock/javascript-sdk v4.9.0 upgrade. In v4.8.0+, when logoutRedirectUri is provided, the SDK now triggers signoff via window.location.assign() (a full page navigation) rather than a fetch() call, which Playwright cannot reliably intercept through waitForResponse(). Our test still validates successful logout through the existing revokeCall await and the Username/Password Form visibility assertion.
Tip
✅ We verified this fix by re-running @forgerock/davinci-suites:e2e-ci--src/basic.test.ts.
diff --git a/e2e/davinci-suites/src/basic.test.ts b/e2e/davinci-suites/src/basic.test.ts
index 1da585de4..43002ae46 100644
--- a/e2e/davinci-suites/src/basic.test.ts
+++ b/e2e/davinci-suites/src/basic.test.ts
@@ -40,14 +40,8 @@ test('Test happy paths on test page', async ({ page }) => {
return true;
}
});
- const signoff = page.waitForResponse((response) => {
- if (response.url().includes('/signoff') && response.status() === 302) {
- return true;
- }
- });
await logoutButton.click();
await revokeCall;
- await signoff;
await expect(page.getByText('Username/Password Form')).toBeVisible();
});
test('ensure query params passed to start are sent off in authorize call', async ({ page }) => {
Or Apply changes locally with:
npx nx-cloud apply-locally 3pbc-MurB
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
This PR contains the following updates:
4.7.0→4.9.0Release Notes
ForgeRock/forgerock-javascript-sdk (@forgerock/javascript-sdk)
v4.9.0Compare Source
Minor Changes
#571
03135cfThanks @cameronwhitworthforgerock! - Added support for Conditional UI elements with WebAuthN#581
1253482Thanks @SteinGabriel! - fix(protect): update Protect callback with new Signals SDK configPatch Changes
#577
1fb1e57Thanks @thomas-schofield-fr! - WebAuthn improvementsasScriptis truev4.8.3Compare Source
Patch Changes
#565
0795917Thanks @ryanbas21! - remove shared array buffer type from webauthn ParsedCredentials.f35d9b2Thanks @ryanbas21! - fixes a bad export syntax in package.json90099e5Thanks @cerebrl! - This aligns ping-protect and protect initialize callbacks to the new Journey Nodes#564
0ddd28fThanks @ancheetah! - Add support for KBAallowUserDefinedQuestionsflagv4.8.2: @forgerock/javascript-sdk@4.8.2Compare Source
@forgerock/javascript-sdk@4.8.1 Latest
Patch Changes
#544 58360de Thanks @ryanbas21! - Fix condition for determining session endpoint request for terminating session in AIC/AM
[Fixing bad release of 4.8.1]
v4.8.1Compare Source
Patch Changes
58360deThanks @ryanbas21! - Fix condition for determining session endpoint request for terminating session in AIC/AMv4.8.0Compare Source
Minor Changes
#535
a5daf4cThanks @cerebrl! - Add new PingOne signoff, remove unneeded /session call, add flag for iframe#537
fc00259Thanks @cerebrl! - Add feature to provide JSON outcome response to callback if requestedConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.