feat(ci): add StackBlitz templates for e2e apps#540
Conversation
|
📝 WalkthroughWalkthroughThe CI workflow publish step now includes an additional ChangesCI Publish Command
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 83bde57
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
More templates
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed 9ba6385 to https://ForgeRock.github.io/ping-javascript-sdk/pr-540/9ba63852044f6d4573a2a6837c32ceae72145d75 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/oidc-client - 35.3 KB (new) 14 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (23.13%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 18.07% 23.13% +5.06%
==========================================
Files 155 161 +6
Lines 24398 25602 +1204
Branches 1203 1614 +411
==========================================
+ Hits 4410 5924 +1514
+ Misses 19988 19678 -310 🚀 New features to boost your workflow:
|
|
How are the templates useful? Is the idea so that we can copy paste the package.json into our e2e locally so we can run the test suites? Also, the templates generated by Stackblitz don't seem to boot up the application in the browser. There might be some error I'm not seeing. |
ryanbas21
force-pushed
the
feat/stackblitz-templates
branch
from
5615d50 to
f528f61
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We determined these e2e failures are unrelated to this PR's changes, which only affect CI publishing configuration. The same failures are reproducible in branch 576, confirming a pre-existing issue with the external PingAM/ForgeRock OAuth2 service returning invalid_request errors for all authentication flows. The affected projects (@forgerock/protect-suites, @forgerock/oidc-suites) were not touched by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
ryanbas21
force-pushed
the
feat/stackblitz-templates
branch
from
f528f61 to
33d5a85
Compare
ryanbas21
force-pushed
the
feat/stackblitz-templates
branch
3 times, most recently
from
60a7d52 to
0ee0434
Compare
ryanbas21
force-pushed
the
feat/stackblitz-templates
branch
5 times, most recently
from
536df86 to
b2e51c6
Compare
Adds --template flag to pkg-pr-new so PR comments include interactive StackBlitz links for all e2e apps. Also switches to --pnpm for correct packing in the monorepo.
ryanbas21
force-pushed
the
feat/stackblitz-templates
branch
from
b2e51c6 to
83bde57
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 49: The pkg-pr-new publish step is advertising e2e app templates that are
not yet standalone. Update the ci workflow’s publish command so the `--template`
selection only includes apps that can boot independently, or add a preflight in
the publish flow to skip/reject templates that still rely on workspace/catalog
resolution or `pnpm nx` monorepo scripts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| run: pnpm nx run-many -t build --no-agents | ||
|
|
||
| - run: pnpm pkg-pr-new publish './packages/*' './packages/sdk-effects/*' --pnpm --packageManager=pnpm | ||
| - run: pnpm pkg-pr-new publish './packages/*' './packages/sdk-effects/*' --template './e2e/*-app' --pnpm --packageManager=pnpm |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
fd -p package.json e2e | while read -r pkg; do
echo "== $pkg =="
echo "-- package links --"
jq -r '
((.dependencies // {}) + (.devDependencies // {}) + (.peerDependencies // {}))
| to_entries[]
| select(.value | test("^(workspace:|file:|link:|catalog:)"))
| " \(.key): \(.value)"
' "$pkg" || true
echo "-- scripts --"
jq -r '
(.scripts // {})
| to_entries[]
| " \(.key): \(.value)"
' "$pkg"
echo
done
echo "Potential monorepo-only references:"
rg -n --glob 'e2e/*-app/package.json' '"(workspace:|file:|link:|catalog:)|(\.\./)|(\bnx\b)|(\bpnpm -r\b)|(\bturbo\b)' .Repository: ForgeRock/ping-javascript-sdk
Length of output: 5319
Don't publish the e2e/*-app templates yet
Line 49 now advertises apps that still depend on workspace/catalog resolution and pnpm nx scripts, so pkg-pr-new will keep publishing templates that can't boot in isolation. Gate --template to standalone apps, or add a preflight that rejects monorepo-only deps/scripts before publishing.
🧰 Tools
🪛 zizmor (1.26.1)
[info] 49-49: prefer trusted publishing for authentication (use-trusted-publishing): this command
(use-trusted-publishing)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ci.yml at line 49, The pkg-pr-new publish step is
advertising e2e app templates that are not yet standalone. Update the ci
workflow’s publish command so the `--template` selection only includes apps that
can boot independently, or add a preflight in the publish flow to skip/reject
templates that still rely on workspace/catalog resolution or `pnpm nx` monorepo
scripts.
3 participants
Summary
--template './e2e/*-app'topkg-pr-newso PR comments include interactive StackBlitz links for all e2e apps (davinci, journey, oidc, device-client, protect)--pnpmflag for correctpnpm packbehavior in the monorepo--packageManager=pnpmso PR comments showpnpm addinstall commandsTest plan
pnpm packis used (check CI logs for pack output)Summary by CodeRabbit