Skip to content

SDKS-5192 Remove default configuration examples for reducing logcat overhead#216

Open
vibhorgoswami wants to merge 1 commit into
developfrom
SDKS-5192
Open

SDKS-5192 Remove default configuration examples for reducing logcat overhead#216
vibhorgoswami wants to merge 1 commit into
developfrom
SDKS-5192

Conversation

@vibhorgoswami

@vibhorgoswami vibhorgoswami commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

JIRA Ticket

SDKS-5192

Description

The logcat shows a lot of unnecessary errors when trying to resolve example domains.

Summary by CodeRabbit

  • Chores
    • Removed obsolete sample app configuration content from the bundled assets.
    • Streamlined the sample project by clearing out unused configuration files.

@vibhorgoswami vibhorgoswami self-assigned this Jun 25, 2026
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b719783e-ca30-4a66-bf84-dea6b35dd7c6

📥 Commits

Reviewing files that changed from the base of the PR and between 75aad51 and 39b8106.

📒 Files selected for processing (3)
  • samples/pingsampleapp/src/main/assets/DaVinciJsonConfig.json
  • samples/pingsampleapp/src/main/assets/journeyJsonConfig.json
  • samples/pingsampleapp/src/main/assets/openIdJsonConfig.json
💤 Files with no reviewable changes (3)
  • samples/pingsampleapp/src/main/assets/DaVinciJsonConfig.json
  • samples/pingsampleapp/src/main/assets/journeyJsonConfig.json
  • samples/pingsampleapp/src/main/assets/openIdJsonConfig.json

📝 Walkthrough

Walkthrough

The sample app asset JSON configuration files were cleared or removed: DaVinciJsonConfig.json and openIdJsonConfig.json were emptied, and journeyJsonConfig.json was deleted.

Changes

Cohort / File(s) Summary
Sample asset configuration cleanup
samples/pingsampleapp/src/main/assets/DaVinciJsonConfig.json, samples/pingsampleapp/src/main/assets/journeyJsonConfig.json, samples/pingsampleapp/src/main/assets/openIdJsonConfig.json
Removed the JSON configuration contents from the sample app assets; one file was deleted and the other two were left empty.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • spetrov
  • witrisna

Poem

🐇 I hopped through the sample stash,
and found the config files made a splash.
One vanished, two went light and bare,
now quiet assets sit with air.
Tiny hops, and all is still.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: removing default config examples to reduce logcat overhead.
Description check ✅ Passed The description includes the JIRA ticket and a brief summary of the issue being addressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch SDKS-5192

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.41%. Comparing base (75aad51) to head (39b8106).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #216      +/-   ##
=============================================
+ Coverage      44.39%   44.41%   +0.02%     
  Complexity      1393     1393              
=============================================
  Files            316      316              
  Lines           9760     9760              
  Branches        1495     1495              
=============================================
+ Hits            4333     4335       +2     
  Misses          4863     4863              
+ Partials         564      562       -2     
Flag Coverage Δ
integration-tests 28.59% <ø> (+0.02%) ⬆️
unit-tests 26.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vibhorgoswami vibhorgoswami marked this pull request as ready for review June 25, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant