SDKS-5116: Surface distinct wrong-number failure for Push Number Challenge by vibhorgoswami · Pull Request #211 · ForgeRock/ping-android-sdk

vibhorgoswami · 2026-06-15T22:51:20Z

JIRA Ticket

Description

This PR update the Ping Android mfa/push module so that AM 400 responses for wrong Push Number Challenge selections propagate as a distinct failure instead of being swallowed and returned as false.

Summary by CodeRabbit

New Features
- Added a dedicated exception for Push Number Challenge authentication failures (HTTP 400 with number challenge present).
Bug Fixes
- Updated Push authentication to throw the new exception and extract a helpful message from the response body.
- Ensured Push notification approval propagates this exception unchanged (not wrapped as a generic error).
Documentation
- Clarified challenge approval behavior for “wrong Push Number Challenge selection.”
Tests
- Added unit tests covering the new 400/500 behaviors and verifying the exception is not wrapped during approval.

coderabbitai · 2026-06-15T22:51:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dabaa322-612f-46c8-a031-f033da7a9c4b

📥 Commits

Reviewing files that changed from the base of the PR and between 84965af and 2d05a49.

📒 Files selected for processing (7)

foundation/utils/src/main/kotlin/com/pingidentity/exception/ApiException.kt
mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PingAMPushResponder.kt
mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PushClient.kt
mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PushService.kt
mfa/push/src/main/kotlin/com/pingidentity/mfa/push/exception/PushNumberChallengeException.kt
mfa/push/src/test/kotlin/com/pingidentity/mfa/push/PingAMPushResponderTest.kt
mfa/push/src/test/kotlin/com/pingidentity/mfa/push/PushServiceTest.kt

✅ Files skipped from review due to trivial changes (1)

mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PushClient.kt

🚧 Files skipped from review as they are similar to previous changes (6)

mfa/push/src/main/kotlin/com/pingidentity/mfa/push/exception/PushNumberChallengeException.kt
mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PushService.kt
foundation/utils/src/main/kotlin/com/pingidentity/exception/ApiException.kt
mfa/push/src/test/kotlin/com/pingidentity/mfa/push/PingAMPushResponderTest.kt
mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PingAMPushResponder.kt
mfa/push/src/test/kotlin/com/pingidentity/mfa/push/PushServiceTest.kt

📝 Walkthrough

Walkthrough

ApiException is changed to an open class, enabling a new PushNumberChallengeException subclass that carries an HTTP status and message. PingAMPushResponder.authenticate throws this exception on HTTP 400 when a numbersChallenge is present and rethrows it explicitly; PushService.approveNotification also rethrows it unwrapped. PushClient KDoc is updated, and new unit tests cover all scenarios.

Changes

Push Number Challenge Exception Handling

Layer / File(s)	Summary
ApiException opened and PushNumberChallengeException introduced `foundation/utils/src/main/kotlin/com/pingidentity/exception/ApiException.kt`, `mfa/push/src/main/kotlin/com/pingidentity/mfa/push/exception/PushNumberChallengeException.kt`	`ApiException` is changed from `class` to `open class` and copyright updated to 2026. `PushNumberChallengeException(status: Int, message: String)` is added as a subclass, forwarding its fields to `ApiException`.
Exception thrown and rethrown in PingAMPushResponder and PushService `mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PingAMPushResponder.kt`, `mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PushService.kt`, `mfa/push/src/main/kotlin/com/pingidentity/mfa/push/PushClient.kt`	`PingAMPushResponder.authenticate` throws `PushNumberChallengeException` on HTTP 400 when `numbersChallenge` is present, parses the error message from the response body, rethrows it in a dedicated catch block, and updates logger initialization. `PushService.approveNotification` adds a dedicated catch to rethrow `PushNumberChallengeException` unwrapped. `PushClient` KDoc documents the new failure path and removes an unused import.
Unit tests `mfa/push/src/test/kotlin/com/pingidentity/mfa/push/PingAMPushResponderTest.kt`, `mfa/push/src/test/kotlin/com/pingidentity/mfa/push/PushServiceTest.kt`	`PingAMPushResponderTest` adds four new tests: 400+numbersChallenge throws `PushNumberChallengeException` with status 400, message extraction from response body, 400 without numbersChallenge returns false, and 500 returns false. `PushServiceTest` adds one new test asserting `PushNumberChallengeException` propagates unwrapped from `approveNotification`. Two existing tests receive a minor `Date` constructor fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop hop, a number went wrong,
The challenge replied with a 400 song.
No more swallowed in silence, no generic disgrace—
PushNumberChallengeException takes its place!
Open the class, let the subtype through,
The rabbit checks statuses—one, two, three, phew! 🎯

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: surfacing a distinct wrong-number failure for Push Number Challenge as a separate exception instead of masking it as a generic false return.
Description check	✅ Passed	The description includes all required sections (JIRA ticket link and description) and provides clear context about the change. It explains the problem, solution, and the benefit to callers.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch SDKS-5116

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-06-15T23:00:39Z

Codecov Report

❌ Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.08%. Comparing base (ed0f5d6) to head (2d05a49).

Files with missing lines	Patch %	Lines
...n/com/pingidentity/mfa/push/PingAMPushResponder.kt	9.09%	10 Missing ⚠️
...in/kotlin/com/pingidentity/mfa/push/PushService.kt	0.00%	2 Missing ⚠️
...mfa/push/exception/PushNumberChallengeException.kt	0.00%	2 Missing ⚠️
.../kotlin/com/pingidentity/exception/ApiException.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #211      +/-   ##
=============================================
- Coverage      44.12%   44.08%   -0.04%     
  Complexity      1393     1393              
=============================================
  Files            316      317       +1     
  Lines           9756     9769      +13     
  Branches        1495     1500       +5     
=============================================
+ Hits            4305     4307       +2     
- Misses          4887     4900      +13     
+ Partials         564      562       -2

Flag	Coverage Δ
integration-tests	`28.22% <6.25%> (-0.04%)`	⬇️
unit-tests	`26.00% <0.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…lenge

witrisna · 2026-06-23T20:29:54Z

            val handler = pushHandlers[platform] ?: throw MfaException("No handler for platform: $platform")

            // Send the approval with any additional parameters
            val result = handler.sendApproval(credential, notification, params)


Is sendApproval client facing interface? Can we change the signature? For approval failure, it can return false or exception, I would prefer to change it as a Result object.

spetrov

LGTM!

spetrov · 2026-06-23T20:43:25Z

            // Check if the response was successful
            if (response.status.isSuccess()) {
                return@withContext true
+            } else if (response.status == 400 && notification.numbersChallenge != null) {


Consider replacing 400 with HttpURLConnection.HTTP_BAD_REQUEST for better readability.

vibhorgoswami self-assigned this Jun 15, 2026

coderabbitai Bot temporarily deployed to github-pages June 15, 2026 22:58 Inactive

vibhorgoswami force-pushed the SDKS-5116 branch from 20a2cd0 to 84965af Compare June 16, 2026 22:00

coderabbitai Bot temporarily deployed to github-pages June 16, 2026 22:05 Inactive

vibhorgoswami requested review from rodrigoareis and spetrov June 16, 2026 22:45

SDKS-5116: Surface distinct wrong-number failure for Push Number Chal…

2d05a49

…lenge

vibhorgoswami force-pushed the SDKS-5116 branch from 84965af to 2d05a49 Compare June 16, 2026 23:14

vibhorgoswami marked this pull request as ready for review June 16, 2026 23:14

coderabbitai Bot temporarily deployed to github-pages June 16, 2026 23:19 Inactive

vibhorgoswami requested a review from witrisna June 17, 2026 19:32

witrisna reviewed Jun 23, 2026

View reviewed changes

spetrov approved these changes Jun 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDKS-5116: Surface distinct wrong-number failure for Push Number Challenge#211

SDKS-5116: Surface distinct wrong-number failure for Push Number Challenge#211
vibhorgoswami wants to merge 1 commit into
developfrom
SDKS-5116

vibhorgoswami commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

witrisna Jun 23, 2026

Uh oh!

spetrov left a comment

Uh oh!

spetrov Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

vibhorgoswami commented Jun 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JIRA Ticket

Description

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

witrisna Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

spetrov left a comment

Choose a reason for hiding this comment

Uh oh!

spetrov Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

vibhorgoswami commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

codecov Bot commented Jun 15, 2026 •

edited

Loading