Revise installation steps and update command syntax#3
Conversation
Updated installation commands and adjusted step numbering in README.
Reviewer's GuideUpdates Termux installation instructions in README to use non-sudo pkg/apt commands, adds a missing dependency, and renumbers/expands the setup steps for clarity and correctness. Flow diagram for updated Termux installation and setup stepsflowchart TD
A[Open Termux with internet connection] --> B[Run apt update && apt upgrade -y]
B --> C[Run apt install git python3 -y]
C --> D[pkg install python-cryptography]
D --> E[pip install google-api-python-client google-auth-httplib2 google-auth-oauthlib]
E --> F[git clone https://github.com/FollowNaim/TokenPickle]
F --> G[Move credentials.json to /sdcard]
G --> H[termux-setup-storage and copy credentials.json into TokenPickle]
H --> I[Run python3 GenerateTokenPickle.py]
I --> J[Copy token.pickle to /sdcard]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Step 2 already runs
apt update && apt upgrade -y, so the new Step 3 (apt update && apt upgrade) appears redundant; consider either removing Step 3 or clarifying why a second update/upgrade is needed. - The revised command sequence mixes
aptandpkgand no longer installspython3-pip; if Termux requirespkgand a separate pip installation, it may help to standardize the package manager and explicitly ensurepipis available before using it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Step 2 already runs `apt update && apt upgrade -y`, so the new Step 3 (`apt update && apt upgrade`) appears redundant; consider either removing Step 3 or clarifying why a second update/upgrade is needed.
- The revised command sequence mixes `apt` and `pkg` and no longer installs `python3-pip`; if Termux requires `pkg` and a separate pip installation, it may help to standardize the package manager and explicitly ensure `pip` is available before using it.
## Individual Comments
### Comment 1
<location path="README.md" line_range="60" />
<code_context>
```
-### 11. You'll find a url https://accounts.google.com/o/oauth2/=offline like this. just copy this url and paste on browser and login into your google account. that's it. you'll see 'The authentication flow has completed. You may close this window' this massage. then you're done.
+### 12. You'll find a url https://accounts.google.com/o/oauth2/=offline like this. just copy this url and paste on browser and login into your google account. that's it. you'll see 'The authentication flow has completed. You may close this window' this massage. then you're done.
-### 12.
</code_context>
<issue_to_address>
**issue (typo):** Correct typos and phrasing in the OAuth URL instructions.
For example, you could revise this step to:
`### 12. You'll see a URL like https://accounts.google.com/o/oauth2/=offline. Copy this URL, paste it into your browser, and log in to your Google account. You'll then see 'The authentication flow has completed. You may close this window' — this message means you're done.`
This fixes capitalization, grammar (“URL”, “paste it into your browser”, “log in to”, “message”) and sentence starts.
```suggestion
### 12. You'll see a URL like https://accounts.google.com/o/oauth2/=offline. Copy this URL, paste it into your browser, and log in to your Google account. You'll then see 'The authentication flow has completed. You may close this window' — this message means you're done.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ``` | ||
|
|
||
| ### 11. You'll find a url https://accounts.google.com/o/oauth2/=offline like this. just copy this url and paste on browser and login into your google account. that's it. you'll see 'The authentication flow has completed. You may close this window' this massage. then you're done. | ||
| ### 12. You'll find a url https://accounts.google.com/o/oauth2/=offline like this. just copy this url and paste on browser and login into your google account. that's it. you'll see 'The authentication flow has completed. You may close this window' this massage. then you're done. |
There was a problem hiding this comment.
issue (typo): Correct typos and phrasing in the OAuth URL instructions.
For example, you could revise this step to:
### 12. You'll see a URL like https://accounts.google.com/o/oauth2/=offline. Copy this URL, paste it into your browser, and log in to your Google account. You'll then see 'The authentication flow has completed. You may close this window' — this message means you're done.
This fixes capitalization, grammar (“URL”, “paste it into your browser”, “log in to”, “message”) and sentence starts.
| ### 12. You'll find a url https://accounts.google.com/o/oauth2/=offline like this. just copy this url and paste on browser and login into your google account. that's it. you'll see 'The authentication flow has completed. You may close this window' this massage. then you're done. | |
| ### 12. You'll see a URL like https://accounts.google.com/o/oauth2/=offline. Copy this URL, paste it into your browser, and log in to your Google account. You'll then see 'The authentication flow has completed. You may close this window' — this message means you're done. |
Updated installation commands and adjusted step numbering in README.
Summary by Sourcery
Update Termux installation instructions and step ordering in the README for generating Google API token.pickle.
Documentation: