Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a README documenting a new automated publishing workflow for flowise-embed and flowise-embed-react, along with an update to .npmignore to exclude the .github directory. Feedback indicates that the actual GitHub Actions workflow file described in the documentation is missing from the current changes. Additionally, there are concerns regarding the use of devDependencies for what appears to be a runtime dependency in the React package, and inconsistencies in the documentation regarding whether npm or yarn is the intended package manager.
| @@ -0,0 +1,92 @@ | |||
| # Publish Workflow | |||
There was a problem hiding this comment.
The pull request description mentions the creation of a new publishing job, but the corresponding GitHub Actions workflow file (e.g., .github/workflows/publish.yml) is not included in the current changes. Please ensure the workflow file is added to the repository.
.github/README.md
Outdated
|
|
||
| ### Dependency update in FlowiseEmbedReact | ||
|
|
||
| The workflow sets `devDependencies.flowise-embed` to the exact new version using `npm pkg set`. This changes the specifier (e.g. from `"latest"` to `"3.1.3"`), which forces yarn to re-resolve from the registry and update `yarn.lock`. Both `package.json` and `yarn.lock` are committed back to the repo. |
There was a problem hiding this comment.
The documentation indicates that flowise-embed is updated within devDependencies for the FlowiseEmbedReact package. If flowise-embed-react is a wrapper that depends on flowise-embed at runtime, it should typically be listed under dependencies or peerDependencies. Using devDependencies may result in the dependency not being installed for end-users of the React package.
.github/README.md
Outdated
|
|
||
| ### Husky suppression | ||
|
|
||
| `HUSKY=0` is set during `yarn install` for FlowiseChatEmbed to prevent the `prepare` script (`husky install`) from failing in CI where there's no git hook context. |
There was a problem hiding this comment.
There is an inconsistency regarding the package manager for FlowiseChatEmbed. While this line mentions yarn install, other parts of the documentation (lines 73, 77) and the file list for this repository (line 91, which omits yarn.lock) suggest that npm is used. Consider updating this for consistency.
|
create we test this out first on maybe like a cloned chatembed/react repos to npm? |
| @@ -0,0 +1,159 @@ | |||
| # Publish Workflow | |||
There was a problem hiding this comment.
I suggest we move this out of the workflow repo as this becomes more of an internal information for oss maintainers
(I also plan to remove the publish part of the README in agentflow sdk as they were added before we have github actions to outline the flow).
| run: | | ||
| npm pkg set "version=${NEW_VERSION}" | ||
| npm pkg set "devDependencies.flowise-embed=${NEW_VERSION}" | ||
| yarn upgrade flowise-embed@${NEW_VERSION} |
There was a problem hiding this comment.
Nit: quote this — yarn upgrade "flowise-embed@${NEW_VERSION}" — to be defensive against shell interpretation
| .github | ||
| rollup.config.js | ||
| tailwind.config.cjs | ||
| tsconfig.json No newline at end of file |
| fi | ||
|
|
||
| - name: Checkout FlowiseChatEmbed | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Minor: bump to actions/checkout@v6 and actions/setup-node@v6 or you will likely see below warnings:
| env: | ||
| VERSION: ${{ needs.dry-run.outputs.version }} | ||
| TAG: ${{ inputs.tag }} | ||
| GH_TOKEN: ${{ secrets.PAT_GITHUB }} |
There was a problem hiding this comment.
Non-blocker: once these repos are consolidated into the monorepo, the PAT_GITHUB should be replaced with the built-in GITHUB_TOKEN since cross-repo access won't be needed anymore.
3 participants
FLOWISE-460
Creates a new publishing job that will handle updating the
FlowiseChatEmbedandFlowiseReactEmbedpackages.Checkout the Readme to go over the process.
The job handles publishing the
FlowiseChatEmbedpackage first then polls for the changes to propagate. Once they propagate thenFlowiseReactEmbedis built and published with the latest version.We could have had this be 2 separate actions 1 in each repo, but having them together means when/if we move repos this will make it much simpler to trim that job and just use the workspace version.