Skip to content

Fix sidebar active route sync when clicking Flowise logo #6580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cgb102000 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −15
Open

Fix sidebar active route sync when clicking Flowise logo #6580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions packages/ui/src/layout/MainLayout/Sidebar/MenuList/NavItem/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types'
import { forwardRef, useEffect } from 'react'
import { Link } from 'react-router-dom'
import { Link, useLocation } from 'react-router-dom'
import { useDispatch, useSelector } from 'react-redux'

// material-ui
Expand Down Expand Up @@ -77,23 +77,23 @@ const NavItem = ({ item, level, navType, onClick, onUploadFile }) => {
}
}

// active menu item on page load
const location = useLocation()

useEffect(() => {
if (navType === 'MENU') {
const currentIndex = document.location.pathname
.toString()
.split('/')
.findIndex((id) => id === item.id)
if (currentIndex > -1) {
dispatch({ type: MENU_OPEN, id: item.id })
}
if (!document.location.pathname.toString().split('/')[1]) {
itemHandler('chatflows')
}
if (navType !== 'MENU') return

const pathnameParts = location.pathname.toString().split('/')
const activePathSegment = pathnameParts[1]

if (!activePathSegment) {
itemHandler('chatflows')
return
}

// eslint-disable-next-line react-hooks/exhaustive-deps
}, [navType])
if (activePathSegment === item.id) {
dispatch({ type: MENU_OPEN, id: item.id })
}
}, [dispatch, item.id, location.pathname, navType, itemHandler])
Comment on lines 82 to +96

@gemini-code-assist gemini-code-assist Bot Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

An infinite loop is triggered when navigating to the root path (/).

Cause

  1. itemHandler is a standard function recreated on every render.
  2. Since itemHandler is included in the useEffect dependency array, any re-render triggers the effect.
  3. When on the root path (/), !activePathSegment is true, so itemHandler('chatflows') is called.
  4. This dispatches Redux actions, updating the Redux store.
  5. The Redux state update triggers a re-render of NavItem (via useSelector), recreating itemHandler and triggering the useEffect again, resulting in an infinite loop.

Solution

We can simplify the logic by defaulting activePathSegment to 'chatflows' when it is empty, and only dispatching MENU_OPEN when activePathSegment === item.id. This completely removes the need to call itemHandler inside useEffect, removing it from the dependency array and eliminating the infinite loop entirely. It also avoids redundant dispatches from other NavItem components.

    useEffect(() => {
        if (navType !== 'MENU') return

        const pathnameParts = location.pathname.toString().split('/')
        const activePathSegment = pathnameParts[1] || 'chatflows'

        if (activePathSegment === item.id) {
            dispatch({ type: MENU_OPEN, id: item.id })
        }
    }, [dispatch, item.id, location.pathname, navType])


return (
<ListItemButton
Expand Down