Skip to content

Fix Flowise 709 Make Custom MCP stdio command allowlist operator-controlled#6578

Open
yau-wd wants to merge 1 commit into
mainfrom
fix/flowise-709-custom-mcp-allowed-commands
Open

Fix Flowise 709 Make Custom MCP stdio command allowlist operator-controlled#6578
yau-wd wants to merge 1 commit into
mainfrom
fix/flowise-709-custom-mcp-allowed-commands

Conversation

@yau-wd

@yau-wd yau-wd commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

FLOWISE-709

@yau-wd yau-wd self-assigned this Jun 29, 2026
@yau-wd yau-wd added the bug Something isn't working label Jun 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the CUSTOM_MCP_ALLOWED_COMMANDS environment variable, allowing operators to configure an allow-list of permitted commands for Custom MCP stdio configurations, defaulting to none. It updates the validation logic in core.ts and adds comprehensive unit tests to verify the allow-list behavior. The review feedback suggests adding an explicit type check to ensure serverParams.command is a string before validation to prevent type confusion and bypasses.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/components/nodes/tools/MCP/core.ts
@yau-wd yau-wd requested a review from igor-magun-wd June 29, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants