feature: custom endpoint host for AWS Embedding Node#6264
Open
rohan-patil2 wants to merge 2 commits intoFlowiseAI:mainfrom
Open
feature: custom endpoint host for AWS Embedding Node#6264rohan-patil2 wants to merge 2 commits intoFlowiseAI:mainfrom
rohan-patil2 wants to merge 2 commits intoFlowiseAI:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AWS Bedrock Embedding node to version 5.1 and introduces a 'Custom Endpoint Host' configuration option, allowing users to override the default AWS Bedrock endpoint. It also refactors the model selection logic to use an 'effectiveModel' variable for consistency. A review comment correctly identified a potential runtime error where 'effectiveModel' could be undefined if no model is provided, which would cause a crash when checking for Cohere models; a suggestion was provided to throw an explicit error in this case.
HenryHengZJ
approved these changes
Apr 22, 2026
rohan-patil2
force-pushed
the
feature/custom-embedding-host-bedrock
branch
from
54dcc0a to
121b8dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom endpoint host for the AWS Embedding node was missing, which prevented connections to the cross-account AWS Bedrock environment.