Skip to content

build: remove a-vaadin-helper dependency - #150

Merged
paodb merged 1 commit into
masterfrom
build/remove-a-vaadin-helper
Oct 26, 2026
Merged

paodb merged 1 commit into
masterfrom
build/remove-a-vaadin-helper

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Removes the unused org.vaadin.artur:a-vaadin-helper dependency from pom.xml. Nothing under src/ references it, and the jar ships frontend sources under the deprecated META-INF/resources/frontend/ location.

mvn clean install passes. ViewIT fails both with and without this change (see #149).

Close #148

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed a Maven dependency. No user-facing behavior changes are noted.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9cf6c8d2-e11b-4d88-a66c-66242a13b231
Commits

Reviewing files that changed from the base of the PR and between 6dac9a5 and 876cc84.

Files selected for processing: 1
  • pom.xml
Files with no reviewable changes: 1
  • pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Maven configuration removes the org.vaadin.artur:a-vaadin-helper:1.7.1 dependency.

Changes

Dependency removal

Layer / File(s) Summary
Remove the unused dependency
pom.xml
The Maven dependencies no longer include org.vaadin.artur:a-vaadin-helper:1.7.1.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 876cc

No dependency-related breakage was identified. The change is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the main change: removing the unused a-vaadin-helper dependency.
Linked Issues check Passed The PR removes the org.vaadin.artur:a-vaadin-helper:1.7.1 dependency from pom.xml, as required by issue #148. The PR reports that mvn clean install passes without the dependency. The PR also rep…
Out of Scope Changes check Passed The whole-PR diff contains only the removal of the a-vaadin-helper dependency from pom.xml. This change directly implements issue #148. No unrelated changes are present.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The PR removes the org.vaadin.artur:a-vaadin-helper:1.7.1 dependency from pom.xml, as required by issue #148. The PR reports that mvn clean install passes without the dependency. The PR also reports that ViewIT has the same failure with and without this change, so the reported integration-test failure is not a regression from this PR.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@javier-godoy
javier-godoy marked this pull request as ready for review October 26, 2026 17:31
@paodb
paodb merged commit 243f4a9 into master Oct 26, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Oct 26, 2026
@paodb
paodb deleted the build/remove-a-vaadin-helper branch October 26, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Remove a-vaadin-helper dependency

2 participants