Hide yearly billing toggle if there are no yearly billing deets to show - #8232
Open
knolleary wants to merge 1 commit into
Open
Hide yearly billing toggle if there are no yearly billing deets to show#8232knolleary wants to merge 1 commit into
knolleary wants to merge 1 commit into
Conversation
11 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8232 +/- ##
=======================================
Coverage 76.20% 76.20%
=======================================
Files 443 443
Lines 23728 23728
Branches 6315 6315
=======================================
Hits 18081 18081
Misses 5647 5647
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 task
n-lark
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative fix for #8218 - replaces #8221
Rather than rip out the toggle, this fixes up the conditional logic for whether it is shown or not. They already had a
v-ifconditional on, but the value wasn't being set consistently.I have also updated the code that mapped a blank pricing detail to display 'free' so that it no longer does that. We don't have a free tier - and it only saved having to type the word 'free' into the pricing description box.