Move round feature enablement - #8155
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8155 +/- ##
==========================================
- Coverage 76.19% 75.79% -0.41%
==========================================
Files 443 446 +3
Lines 23726 24108 +382
Branches 6314 6431 +117
==========================================
+ Hits 18079 18272 +193
- Misses 5647 5836 +189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I had to check in a new |
|
Still need to double check, but with the new product tiers it is possible for a customer to buy a license for both hub and edge to unlock the full feature set. So we need to handle such license types. I propose we allow the type to be a I suggest we have a codified version of the tickbox table that maps feature to tiers (or tiers to features... not such which way around makes the most sense...) And then a utility function |
|
Can't that just be the There is also the stuff about maybe including the cert nodes tokens in the license and the new feature listed about access to different BluePrint libraries (that we have not done any planing/design for yet) |
b67f57a to
e3ca44a
Compare
|
I don't think it can be. We'd want the platform to be able to report what tier they are licensed for - using |
|
OK, so we'll need to start again here, multi or mixed tier licenses was not in the original spec issue. |
knolleary
left a comment
There was a problem hiding this comment.
Need to move bom to hub only.
I do think it would be better to have a map of tier to available features that can be more readily compared to the pricing table to spot any inconsistencies. As it is, we need to step through the code to work out what features have been enabled for each tier and risks things slipping through.
I will do a deeper review to check for any other updates needed.
| // Set the Bill of Materials Feature Flag | ||
| app.config.features.register('bom', true, true) |
There was a problem hiding this comment.
BoM has been moved to hub only
There was a problem hiding this comment.
OK, BOM isn't even in the list I was working from
part of FlowFuse/engineering#230
Description
Adds new license tiers and enables features accordingly as laid out in FlowFuse/engineering#230.
The
enterprisetier should continue to add all new features so they are covered by testsRelated Issue(s)
FlowFuse/engineering#230
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel