Add team level support for expert features#7331
Open
cstns wants to merge 9 commits into
Open
Conversation
…m and team-level checks
…point' into team-level-support-for-expert-features
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## inconsistend-backend-gating-of-snapshot-description-endpoint #7331 +/- ##
=============================================================================================
Coverage 76.61% 76.61%
=============================================================================================
Files 405 405
Lines 20638 20658 +20
Branches 5006 5017 +11
=============================================================================================
+ Hits 15811 15827 +16
- Misses 4827 4831 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… `expertInsights`
…e flags to improve gating logic
…qtt subscriptions
…s` in ExpertDrawer component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is part of a nested merge list. Do not merge until its target branch is main.
Description
expertAssistantandexpertInsightswere previously platform-only features with no team-level granularity. All teams either had expert features or none did. Both flags now support team-level opt-out, defaulting to enabled.Backend:
forge/lib/features.js: addedexpertAssistantandexpertInsightsto the feature list and names so they appear as checkboxes in the admin TeamType editorforge/ee/lib/index.js: changedexpertInsightsfrom a private to a public flag so the frontend can check it viaFEATURE_CONFIGSforge/ee/routes/expert/index.js: addedaiandexpertAssistantteam feature checks in the shared preHandler (applies to both/chatand/mcp/features), addedexpertInsightsteam feature check specifically for the/mcp/featuresendpointFrontend:
frontend/src/composables/FeatureChecks.ts: changedexpertAssistantfrom platform-only to platform+team withoptOut: trueand addeddependsOnTeam: 'ai'. AddedexpertInsightsentry with the same pattern.frontend/src/components/expert/Expert.vueandfrontend/src/components/drawers/expert/ExpertDrawer.vue: changed from readingfeatures.expertInsightsdirectly to usingfeaturesCheck.isExpertInsightsFeatureEnabledwhich respects both platform and team level checksfrontend/src/pages/admin/TeamTypes/dialogs/TeamTypeEditDialog.vue: added defaults forexpertAssistantandexpertInsights(both default totrue, opt-out)Related Issue(s)
closes #7315
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel