Conditionally include nr-assistant in device snapshots based on AI flag #7326
Open
cstns wants to merge 3 commits into
Conversation
…rm and team levels
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gate-all-ai-features-begind-ai-platform-and-team-type-flag #7326 +/- ##
==============================================================================================
+ Coverage 76.60% 76.61% +0.01%
==============================================================================================
Files 405 405
Lines 20621 20630 +9
Branches 4998 5002 +4
==============================================================================================
+ Hits 15796 15805 +9
Misses 4825 4825
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s and dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is part of a nested merge list. Do not merge until its target branch is main.
Description
The
@flowfuse/nr-assistantplugin was previously unconditionally included in device modules. It is now only included when AI is enabled at both platform and team level.Changes in
forge/routes/api/deviceLive.js:@flowfuse/nr-assistantis removed from the default modules when AI is disabled@flowfuse/nr-assistantis conditionally injected when AI is enabled, and actively removed from snapshot modules when AI is disabledBoth locations check
app.config.features.enabled('ai') && device.Team.getFeatureProperty('ai', true).Note
Changes to the AI flag do not take effect on running devices immediately. Devices will pick up the updated module list on their next snapshot delivery (e.g. after a new deployment or device restart).
Related Issue(s)
closes #7313
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel