Skip to content

docs(rev): reconcile runtime-readiness planning#150

Merged
abiorh-claw merged 16 commits into
mainfrom
codex/ws-rev-001-plan2-runtime-readiness
Jul 18, 2026
Merged

docs(rev): reconcile runtime-readiness planning#150
abiorh-claw merged 16 commits into
mainfrom
codex/ws-rev-001-plan2-runtime-readiness

Conversation

@Abiorh001

@Abiorh001 Abiorh001 commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

PR Trust Bundle: WS-REV-001-PLAN2

Chunk

WS-REV-001-PLAN2 - REV-02A Runtime Readiness Plan Refresh.

Goal

Make the complete review/revision initiative implementation-ready against
trusted main without starting REV runtime or coding against the still-retired
task contributor fields.

Human-approved intent

Preserve one Project Guide task pipeline, immutable Review/finding/resolution
history, exact leased Submission review, accept-only FinalAcceptance, separate
checker remediation, Review-rooted human revision rebase, and no v0.1
adjudication implementation.

What changed

  • Reconciled the full initiative, active lifecycle/data/replay documents, risks,
    decisions, conformance, test design, and executable/proposed chunk boundaries.
  • Converted oversized future parents into non-executable split records.
  • Added exact checker-remediation causal lineage and final human/checker source
    XOR ownership to future 02C/09A4 contracts.
  • Reconciled merged AUTH-09D-A PR Add actor profile lifecycle and evidence repair #148, migration 0026, and the live AUTH
    catalogue while preserving the separate contributor foundation gate.
  • Added exactly one merge intent for PLAN2 with explicit successor start.

Why it changed

Merged AUTH, ART, CON, and cross-initiative contracts invalidated older planning
assumptions. The prior plan also combined runtime boundaries, mixed human and
checker revision rules, and lacked database-enforceable checker-remediation
causal lineage.

Design chosen

REV owns immutable review/revision lifecycle facts and orchestration. Task owns
guide context and Submission lineage. Checker remediation reuses CheckerRun and
stores remediation_source_checker_run_id; human revision uses
RevisionContextPreparation. CON participates flush-only in the REV-owned commit,
ART stays behind typed capability ports, and AUTH owns authorization plus the
separate contributor clean cut.

Alternatives rejected

  • No synthetic Review or shared origin-neutral revision-obligation entity for
    checker remediation.
  • No separate reviewer guide or reviewer-side rebase.
  • No direct Review-decision inference for submitter contribution; it consumes
    FinalAcceptance.
  • No AUTH ownership of REV source columns/constraints.
  • No adjudication states, queues, actions, policy, or runtime in v0.1.

Scope control

Only the REV initiative, four allowed active product documents, and one PLAN2
merge intent changed. No backend, migration, test, workflow, dependency,
reference specification, AUTH/ART/CON owner plan, or handoff file changed.

Product behavior

This PR activates no product behavior. Planned v0.1 decisions remain accept,
needs_revision, and reject; every committed decision/finding/resolution is
immutable, accept alone creates FinalAcceptance, and checker remediation remains
distinct from Review-rooted human revision.

Acceptance criteria proof

The plan names exact dependencies, lock orders, transaction ownership,
database constraints, migration/backfill refusal, race tests, contribution and
artifact boundaries, child ownership, required reviewers, and explicit stops.
AUTH-09D-A is treated as merged; the contributor foundation remains fail-closed.

Tests/checks run

Diff integrity, four stale-contract scanners, Markdown links, 87 agent-gate
tests, one-head Alembic verification, merge-intent validation, catalogue
arithmetic, and changed-scope scans all pass.

Test delta

No executable test or runtime file changed. No assertion, skip, coverage floor,
or CI gate was weakened.

CI integrity

Current global 78 percent coverage remains unchanged. Future materially changed
task/checker/project areas require persistent focused 90 percent gates in their
own implementation chunks. PLAN2's schema-v2 merge intent validates uniquely.

Reviewer results

Senior engineering, QA/test, security/auth, product/ops, architecture, docs,
reuse/dedup, test delta, and CI integrity all pass after repairs on reviewed SHA
6985909ea83e74de22f1067777be0af2138b28de.

External review

Pending GitHub CI, CodeRabbit, and human PR review.

Remaining risks

The contributor-field foundation has not merged, ART/CON runtime participants
remain future owner work, two duration defaults and human revision exhaustion
semantics require explicit approval, and later migration heads must be refreshed
from current main.

Follow-up work

After PLAN2 merges, automated memory names 02A but does not start it. AUTH must
merge the contributor foundation, then a human must explicitly start a refreshed
02A contract. Every later child follows its own gate.

Human review focus

Review the AUTH/REV ownership boundary, checker versus human revision lineage,
02A/02A2 sequencing, transaction/lock ownership, dormant adjudication boundary,
and absence of runtime changes.

Human merge ownership

Only the user may approve and merge this PR. Merge does not authorize 02A
implementation.

Summary by CodeRabbit

  • Documentation
    • Clarified the review and revision lifecycle, including distinct human-review and checker-remediation paths.
    • Updated lifecycle state, data model, replay, architecture, risk, and decision guidance with stricter lineage, locking, and evidence requirements.
    • Reorganized initiative plans into executable child chunks and non-executable parent planning records.
  • Planning
    • Added the PLAN2 runtime-readiness refresh and supporting review evidence.
    • Confirmed runtime implementation remains blocked; successor work requires explicit approval and start.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Abiorh001, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: db181105-ae1c-4df8-83ea-570446c7fa97

📥 Commits

Reviewing files that changed from the base of the PR and between e311709 and 8524d22.

📒 Files selected for processing (16)
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CHUNK_MAP.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DECISIONS.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/REVIEW_LOG.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/RISKS.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/SOURCE_MANIFEST.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/STATUS.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-03-review-queue-lease-persistence.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-06-claims-preference-timers.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-08-immutable-decision-kernel.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-09A-revision-context-resubmission.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-10-contribution-integration-hidden-composition.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-PLAN2-runtime-readiness-plan-refresh.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN2-external-review-response.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN2-internal-review-evidence.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN2-pr-trust-bundle.md
  • docs/spec_review_lifecycle.md
📝 Walkthrough

Walkthrough

WS-REV-001 planning and lifecycle contracts were refreshed around trusted-main evidence, explicit child starts, CheckerRun-rooted remediation, immutable revision lineage, runtime gating, and non-executable parent splits. No product runtime, migration, or test implementation was added.

Changes

WS-REV-001 planning authority

Layer / File(s) Summary
Planning authority and execution gates
.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/{CHUNK_MAP,PLAN,STATUS,DECISIONS,DISCOVERY,INTENT,CONFORMANCE_MATRIX,RISKS,SOURCE_MANIFEST}.md
Planning authority, owner-gate evidence, trusted-main references, lifecycle decisions, conformance proof, risks, and stop conditions were updated.
Runtime foundation child contracts
.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/*, docs/architecture_data_model.md
PLAN2 and the 02A–02C contracts define guide locking, reactivation, policy lifecycle, submission lineage, proof requirements, and persistence shapes.
Review, remediation, and release semantics
docs/architecture_lifecycle_state_machine.md, docs/operations_revision_replay.md, docs/spec_review_lifecycle.md, .agent-loop/.../chunks/WS-REV-001-08-*, .agent-loop/.../chunks/WS-REV-001-09B-*, .agent-loop/.../chunks/WS-REV-001-10-*
Human-review revision and CheckerRun remediation paths are separated, immutable preparation and source lineage are specified, and release/action dependencies are updated.
Split records and PLAN2 review evidence
.agent-loop/.../chunks/WS-REV-001-{03,04,05,06,07,09A,11,12,12A,13}-*, .agent-loop/.../reviews/*, .agent-loop/merge-intents/WS-REV-001-PLAN2.json
Oversized parents are marked non-executable, child ownership is recorded, PLAN2 evidence is added, and the next chunk requires an explicit start.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Suggested reviewers: abiorh-claw

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change: refreshing REV runtime-readiness planning.
Description check ✅ Passed The description covers the required bundle sections and key intent, though some template fields like merge intent path and evidence blocks are abbreviated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ws-rev-001-plan2-runtime-readiness

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-03-review-queue-lease-persistence.md:
- Around line 12-14: Make WS-REV-001-03B the sole owner of normalized immutable
ReviewPacketManifest/item persistence, including its schema and migrations,
while preserving the exact packet-membership contract dependency. In
WS-REV-001-06-claims-preference-timers.md lines 9-10, remove or narrow manifest
ownership and explicitly consume 03B’s canonical contract; update both sites so
no duplicate persistence model or migration is implied.

In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-08-immutable-decision-kernel.md:
- Around line 62-66: Update the Verification section of the executable chunk to
explicitly list the concrete focused-test, Ruff, coverage, stale-scan,
agent-gate, merge-intent, and git diff --check commands required before
implementation. Do not defer these commands to a future start contract;
alternatively, explicitly mark the record as non-executable if commands cannot
be defined.

In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-10-contribution-integration-hidden-composition.md:
- Around line 141-146: Align the needs-revision branch’s preparation participant
with the allowed ownership boundary: either consume the task-owned participant
delivered by the 09A children, or add the required task-owned implementation
files and owner gate in this chunk. Update the contract wording and
implementation so it no longer claims a task-owned participant without an
allowed implementation path, while preserving the existing Review-rooted
preparation and rollback behavior.

In @.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DECISIONS.md:
- Around line 157-161: Update the legacy-closure eligibility statement to
require that neither an unambiguous human Review root nor an exact final
needs_revision CheckerRun exists. Restrict the separately authorized legacy
closure to rootless human-review state, excluding valid CheckerRun-rooted tasks
even when no human Review is present; preserve the existing authorization,
evidence-linking, terminal reason, assignment release, and no-record outcomes.

In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN2-pr-trust-bundle.md:
- Around line 59-61: The review scope claims are inconsistent with the
changed-file set because docs/spec_review_lifecycle.md changed. Update
.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN2-pr-trust-bundle.md
lines 59-61 to remove “reference specification” from the unchanged-file claim or
classify the specification among the four active product documents; update
.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN2-internal-review-evidence.md
lines 7-10 to use the same accurate candidate scope and changed-file
classification.

In `@docs/spec_review_lifecycle.md`:
- Line 761: Update the surrounding paragraph in docs/spec_review_lifecycle.md to
remove the executable ownership claim for REV-12A and assign implementation
ownership to REV-12A1 through REV-12A4, while preserving REV-12A as
non-executable. Ensure the release-control terminology matches CHUNK_MAP.md,
D19, README.md, docs/glossary.md, and docs/architecture_lockdown.md.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e626d757-69b6-43ee-8623-470c1688857f

📥 Commits

Reviewing files that changed from the base of the PR and between 99ae4c9 and e311709.

📒 Files selected for processing (36)
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CHUNK_MAP.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CONFORMANCE_MATRIX.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DECISIONS.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DISCOVERY.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/INTENT.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/PLAN.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/REVIEW_LOG.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/RISKS.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/SOURCE_MANIFEST.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/STATUS.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/TEST_DESIGN_WS-REV-001-02.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-02A-guide-activation-sequence.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-02A2-prepared-guide-reactivation.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-02B-review-policy-task-lifecycle.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-02C-submission-attribution-lineage.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-03-review-queue-lease-persistence.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-04-review-chain-persistence.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-05-checker-routing-queue-views.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-06-claims-preference-timers.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-07-review-context-finding-evidence.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-08-immutable-decision-kernel.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-09A-revision-context-resubmission.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-09B-finding-replay-resolution-routing.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-10-contribution-integration-hidden-composition.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-11-admin-revocation-reconciliation.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-12-projection-observability.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-12A-joint-lifecycle-release-control.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-13-live-drill-docs-release.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-PLAN2-runtime-readiness-plan-refresh.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN2-internal-review-evidence.md
  • .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN2-pr-trust-bundle.md
  • .agent-loop/merge-intents/WS-REV-001-PLAN2.json
  • docs/architecture_data_model.md
  • docs/architecture_lifecycle_state_machine.md
  • docs/operations_revision_replay.md
  • docs/spec_review_lifecycle.md

Comment thread .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DECISIONS.md Outdated
Comment thread docs/spec_review_lifecycle.md Outdated
@abiorh-claw
abiorh-claw self-requested a review July 18, 2026 21:49
@abiorh-claw
abiorh-claw merged commit 983b9e5 into main Jul 18, 2026
3 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 18, 2026
@abiorh-claw
abiorh-claw deleted the codex/ws-rev-001-plan2-runtime-readiness branch July 19, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants