Skip to content

WS-CON-001-01: Adopt canonical contribution and compensation contract#144

Merged
abiorh-claw merged 7 commits into
mainfrom
codex/ws-con-001-01
Jul 17, 2026
Merged

WS-CON-001-01: Adopt canonical contribution and compensation contract#144
abiorh-claw merged 7 commits into
mainfrom
codex/ws-con-001-01

Conversation

@Abiorh001

@Abiorh001 Abiorh001 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

PR Trust Bundle: WS-CON-001-01

Chunk

WS-CON-001-01 - Canonical Contract Adoption And Architecture Decision

Risk: L0 direction executed as L1 specification work; SLA P1.

Goal

Publish one repository-owned contribution/compensation specification and ADR
0016, reconciled with merged AUTH, REV, ART, and WS-XINT boundaries, without
changing runtime or archival inputs.

Human-Approved Intent

The human approved the reconciled WS-CON plan, accept-only
Review -> FinalAcceptance -> accepted_submission, ContributionPolicy
superseding the retired economic model, no v0.1 adjudication, and explicit start
of this chunk.

What Changed

  • Added the canonical contribution/compensation specification and ADR 0016.
  • Linked both from README with explicit precedence.
  • Corrected active data-model naming and mirrored numeric/receipt rules.
  • Recorded active-doc inventory, conformance proof, decisions, status, review
    evidence, and one merge intent.

Why It Changed

The archival input and old runtime-oriented chunk documents did not reflect
merged FinalAcceptance, AUTH custody/prepared mutation, optional ART evidence,
dispatcher/handler separation, or the joint release fence. One active contract
is required before schema/runtime chunks proceed.

Design Chosen

  • ContributionPolicy is the only target eligibility policy.
  • TaskAssignment and ReviewLease independently freeze immutable versions.
  • Every valid Review creates reviewer recognition; accept alone creates
    FinalAcceptance and submitter recognition.
  • One mandatory CON participant has separate reviewer and accept-only submitter
    operations; REV stages audit/outbox and the caller commits once.
  • Awards are immutable policy results; adapters only fulfill them after commit.
  • AUTH owns identifier, evaluator, evidence, service admission, and activation;
    22 mappings remain non-final proposals.
  • One shared outbox and one REV-owned controller/fence govern delivery.
  • Quantities use NUMERIC(38, 18) and receipts store only bounded, minimized
    canonical facts.

Alternatives Rejected

  • Direct submitter inference from Review.decision.
  • Manual or independently authorized FinalAcceptance.
  • One nullable cross-actor participant input.
  • CON-owned commit or post-commit contribution repair.
  • A compatibility alias or fallback economic policy.
  • Mandatory ART evidence in the core transaction.
  • Provider-decided award eligibility.
  • Dispatcher authority inherited by handlers.
  • A second CON release controller.
  • Adjudication in v0.1.

Scope Control

Changed files are limited to canonical docs, README precedence, the active
data-model correction, WS-CON initiative artifacts, and exactly one merge
intent. No backend, migration, AUTH/ART/REV-owned runtime contract, workflow,
dependency, test, coverage, or roadmap/export file changed.

The user-owned deleted reference PDF was not staged or committed.

Product Behavior

Runtime behavior is unchanged. The documents define target behavior and keep
all routes hidden until implementation, AUTH activation, and joint release.

Acceptance Criteria Proof

  • ADR 0016 follows independent ADR 0015.
  • Required policy, binding, contribution, award, receipt, status, outbox, audit,
    authorization, adapter, and release contracts are defined.
  • Legacy cleanup is split across 05A/05B with no fallback or implicit unpaid.
  • FinalAcceptance lineage, two operations, single commit, zero core ART calls,
    and no adjudication match merged REV.
  • All 22 action mappings are unregistered and non-final.
  • D11, legacy rows, service authority, and optional evidence remain human gates.
  • /api/v1, secret exclusion, conformance mapping, and archive preservation are
    explicit.

Tests And Checks Run

python3 scripts/check_markdown_links.py
python3 scripts/check_stale_workstream_wording.py
python3 scripts/check_stale_authorization_docs.py
python3 scripts/check_stale_artifact_contracts.py
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python3 -m pytest -q scripts/test_agent_gates.py
git diff --check

All passed; agent gates reported 80 tests passed. Both present archival hashes
matched, the committed reference-spec diff was empty, and the mapping count was
exactly 22.

Test Delta

No tests, scanners, test configuration, or coverage thresholds changed. The
existing tests were run unchanged.

CI Integrity

No workflow, package script, dependency, lint/typecheck command, test runner, or
coverage threshold changed. CI-integrity review passed.

Reviewer Results

Exact reviewed SHA: 0b663f38b4a8fc7058e4e71932d72571d2cc2b6a.

Track Result
Senior engineering PASS
QA/test PASS
Security/auth PASS after receipt/numeric repairs
Product/ops PASS
Architecture PASS
Docs PASS after conformance/inventory repairs
Reuse/dedup PASS
CI integrity PASS

All valid findings were repaired and all tracks passed at the exact SHA with no
remaining findings. No sub-agent session remains open.

External Review

Pending GitHub CI, CodeRabbit, and human PR review. They supplement but do not
replace the completed internal tracks.

Remaining Risks

  • D11 administrative role candidates are still human/AUTH gates.
  • Legacy row classification is still a human migration gate.
  • Protected service identities/actions/static rows are not yet approved.
  • AUTH, REV, task, ART-lineage, outbox, and release runtime prerequisites remain
    unimplemented and must refresh from trusted main per chunk.

Follow-Up Work

The same-initiative successor is WS-CON-001-02A, shared transactional outbox
persistence. It requires a separate explicit start after this PR merges. This
chunk does not start it.

Human Review Focus

  1. Confirm FinalAcceptance and the two-operation transaction boundary.
  2. Confirm ContributionPolicy fully supersedes the retired economic model.
  3. Confirm AUTH owns activation and proposed identifiers stay non-final.
  4. Confirm numeric/unit and provider-receipt minimization decisions.
  5. Confirm open D11, legacy-row, and protected-service gates are acceptable.

Human Merge Ownership

Only the human owner may approve and merge the specific PR. Passing reviewers,
CI, or CodeRabbit do not authorize merge or the next chunk.

Summary by CodeRabbit

  • New Features

    • Added the canonical contribution-and-compensation specification and ADR 0016, defining the contribution→compensation boundary and the required lifecycle/rollback rules.
    • Tightened conformance for policy modeling, adapter bindings, deterministic award/quantity handling, and receipt/audit redaction (including closed failure codes).
  • Documentation

    • Expanded architecture/data-model documentation with stricter numeric/validation semantics and finalized receipt fields/immutability rules.
    • Updated README and multiple initiative documents (review evidence, trust bundle, inventory, status/gates, merge intent, and external review response) to reflect the current approved planning baseline and checkpoints.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 979a2916-a195-4af7-93f8-a838773aae1e

📥 Commits

Reviewing files that changed from the base of the PR and between 2bb7286 and 88e4ac7.

📒 Files selected for processing (15)
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/ACTIVE_DOC_INVENTORY.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/AUTHORIZATION_HANDOFF.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CHUNK_MAP.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CONFORMANCE_MATRIX.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/DECISIONS.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/DISCOVERY.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/INTENT.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/JOINT_RELEASE_HANDOFF.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/PLAN.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/SOURCE_MANIFEST.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/STATUS.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-01-external-review-response.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-01-internal-review-evidence.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-01-pr-trust-bundle.md
  • docs/spec_contribution_compensation.md
🚧 Files skipped from review as they are similar to previous changes (6)
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CHUNK_MAP.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/ACTIVE_DOC_INVENTORY.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-01-internal-review-evidence.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/STATUS.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-01-pr-trust-bundle.md
  • docs/spec_contribution_compensation.md

📝 Walkthrough

Walkthrough

This documentation-only change establishes the canonical contribution and compensation specification with ADR 0016, updates related data-model and conformance documentation, records initiative review evidence, and adds a merge intent. Runtime, CI, tests, dependencies, and archival inputs remain unchanged.

Changes

Canonical contribution compensation boundary

Layer / File(s) Summary
Canonical contract and product model
docs/spec_contribution_compensation.md, docs/decision_0016_contribution_compensation_boundary.md
Defines contribution recognition, FinalAcceptance creation, policy freezing, award and receipt models, and canonical contract precedence.
Transaction, authorization, and fulfillment boundaries
docs/spec_contribution_compensation.md, .agent-loop/.../CONFORMANCE_MATRIX.md, docs/architecture_data_model.md
Specifies atomic review-to-contribution ordering, authority ownership, outbox/audit behavior, fulfillment isolation, lifecycle draining, migration sequencing, conformance requirements, and receipt/data-model constraints.
Documentation authority and model alignment
README.md, .agent-loop/.../ACTIVE_DOC_INVENTORY.md, .agent-loop/.../DECISIONS.md, .agent-loop/.../AUTHORIZATION_HANDOFF.md, .agent-loop/.../PLAN.md, .agent-loop/.../SOURCE_MANIFEST.md
Links canonical documents, records active versus historical documentation scope, and reconciles the trusted-main authorization baseline.
Chunk status and review evidence
.agent-loop/.../CHUNK_MAP.md, .agent-loop/.../STATUS.md, .agent-loop/.../reviews/*, .agent-loop/merge-intents/*
Records completion awaiting human review, validation results, trust-bundle evidence, follow-up sequencing, and explicit human merge ownership.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adopting the canonical contribution and compensation contract for WS-CON-001-01.
Description check ✅ Passed The description covers the required sections and most template details, including scope, design, evidence, reviews, and follow-up work.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ws-con-001-01

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
@.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CONFORMANCE_MATRIX.md:
- Line 6: Update the “Adapter binding” row in CONFORMANCE_MATRIX.md to remove
“matching policy/award references” from the binding requirements. State instead
that policy definitions and awards must reference a binding with matching
project and instrument identity, without modeling policy or award identifiers on
the binding aggregate.

In `@docs/spec_contribution_compensation.md`:
- Around line 336-340: Clarify the receipt redaction vocabulary in
docs/spec_contribution_compensation.md lines 336-340 by prohibiting raw provider
secrets, authentication tokens, and unbounded provider payloads while explicitly
allowing bounded opaque event/reference identifiers required by receipts. Apply
the same raw-versus-bounded terminology to D19 in
docs/decision_0016_contribution_compensation_boundary.md lines 288-293.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 52d1c10c-3fdc-4293-80b9-846cf5967af1

📥 Commits

Reviewing files that changed from the base of the PR and between a947b86 and 2bb7286.

📒 Files selected for processing (12)
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/ACTIVE_DOC_INVENTORY.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CHUNK_MAP.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CONFORMANCE_MATRIX.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/DECISIONS.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/STATUS.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-01-internal-review-evidence.md
  • .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-01-pr-trust-bundle.md
  • .agent-loop/merge-intents/WS-CON-001-01.json
  • README.md
  • docs/architecture_data_model.md
  • docs/decision_0016_contribution_compensation_boundary.md
  • docs/spec_contribution_compensation.md

Comment thread docs/spec_contribution_compensation.md Outdated
@abiorh-claw
abiorh-claw self-requested a review July 17, 2026 23:47
@abiorh-claw
abiorh-claw merged commit e118e33 into main Jul 17, 2026
4 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 17, 2026
@abiorh-claw
abiorh-claw deleted the codex/ws-con-001-01 branch July 18, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants