Plan review and revision lifecycle#128
Conversation
📝 WalkthroughWalkthroughThis planning-only change adds the WS-REV-001 lifecycle plan, architecture records, conformance evidence, risk and status tracking, chunk contracts from planning through live release proof, internal review evidence, revised reference specifications, and an explicit merge-intent gate preventing automatic runtime implementation. ChangesWS-REV-001 planning and lifecycle contracts
Estimated code review effort: 3 (Moderate) | ~30 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-01-canonical-contract-adoption.md:
- Around line 15-22: Update the allowed-file contract in the WS-REV-001
canonical contract document to include the exact WS-IMP archival pair paths
alongside the existing WS-REV entries. Extend the associated SHA256SUMS and
provenance-handling requirements so both WS-IMP files are preserved and hashed
without altering the existing archival rules.
In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-03-review-queue-lease-persistence.md:
- Around line 8-10: Update the activation prerequisite wording in the
ReviewLease chunk to state that activation requires the WS-CON
compensation-policy persistence contract to be merged, while preserving the
reference to its exact lease-freeze foreign-key and field types and the existing
scope boundary.
In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-13-live-drill-docs-release.md:
- Around line 213-214: Update the final conformance test command to run the
complete required suite, including test_alembic.py, test_lifecycle_control.py,
test_tasks.py, test_checkers.py, test_outbox.py, test_audit.py, and
test_config.py, while preserving the existing review, contribution,
compensation, authorization, API-contract, and live-drill tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 216fbea3-b9b3-4d12-aa06-3bbd720bbe4c
📒 Files selected for processing (30)
.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CHUNK_MAP.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CONFORMANCE_MATRIX.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CON_INTEGRATION_REVIEW.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DECISIONS.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DISCOVERY.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/INTENT.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/PLAN.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/REVIEW_LOG.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/RISKS.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/SOURCE_MANIFEST.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/STATUS.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-01-canonical-contract-adoption.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-02-review-policy-task-alignment.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-03-review-queue-lease-persistence.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-04-review-chain-persistence.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-05-checker-routing-queue-views.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-06-claims-preference-timers.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-07-review-context-finding-evidence.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-08-immutable-decision-kernel.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-09A-revision-context-resubmission.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-09B-finding-replay-resolution-routing.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-10-contribution-integration-hidden-composition.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-11-admin-revocation-reconciliation.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-12-projection-observability.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-12A-joint-lifecycle-release-control.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-13-live-drill-docs-release.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-PLAN-review-revision-lifecycle-planning.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN-internal-review-evidence.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN-pr-trust-bundle.md.agent-loop/merge-intents/WS-REV-001-PLAN.json
| ```text | ||
| docs/reference_specs/WS-REV-001-review-lifecycle-specification.md only to restore recorded archival bytes | ||
| docs/reference_specs/WS-REV-001-review-lifecycle-specification.pdf only to restore recorded archival bytes | ||
| docs/reference_specs/WS-REV-001-review-lifecycle-specification(2).md addition-only archival bytes | ||
| docs/reference_specs/WS-REV-001-review-lifecycle-specification(2).pdf addition-only archival bytes | ||
| docs/reference_specs/README.md | ||
| docs/reference_specs/SHA256SUMS | ||
| docs/spec_review_lifecycle.md |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Include the WS-IMP archival pair in the allowed-file contract.
The acceptance criteria require preserving and hashing the WS-IMP pair, but the allowed-file list contains only WS-REV archival paths. A compliant implementation could not satisfy both requirements. Add the exact WS-IMP paths and checksum/provenance handling.
Also applies to: 70-72
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-01-canonical-contract-adoption.md
around lines 15 - 22, Update the allowed-file contract in the WS-REV-001
canonical contract document to include the exact WS-IMP archival pair paths
alongside the existing WS-REV entries. Extend the associated SHA256SUMS and
provenance-handling requirements so both WS-IMP files are preserved and hashed
without altering the existing archival rules.
d1ace16 to
6faccc0
Compare
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-05-checker-routing-queue-views.md:
- Around line 58-59: Update the sentence in the revision lifecycle documentation
to hyphenate the compound modifier as “later-admitted version routes,”
preserving the rest of the wording.
- Around line 51-57: Update the verification commands for the checker routing
and queue views initiative to explicitly run tests covering TaskService routes,
the shared composition assembly, and checker workers, plus lint those paths.
Alternatively, document the existing test locations and commands that assert all
required constructor paths, including rejection of direct TaskService or
CheckerService construction.
In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-07-review-context-finding-evidence.md:
- Around line 40-46: Clarify the review.chain.read rule by defining “owns a
Submission’s exact TaskAssignment” as a server-derived relationship: the actor
must be the assignment’s canonical contributor, and that assignment must be the
one associated with the Submission in the requested chain. Preserve the existing
exclusions and bounded-metadata behavior.
- Around line 107-110: Add the explicit API contract/OpenAPI test verifying
lifecycle routes remain absent to the command block in
.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-07-review-context-finding-evidence.md
lines 107-110, and include the same public-route verification in the revision
cutover gate at
.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-09A-revision-context-resubmission.md
lines 232-236.
In
@.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-13-live-drill-docs-release.md:
- Around line 226-227: Update the coverage command’s lifecycle-control entry to
include the full app/modules/lifecycle_control/* package instead of only
router.py, while preserving the existing 90% threshold and fail-fast behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 77536314-d9aa-4613-af36-333d26112fd1
⛔ Files ignored due to path filters (1)
docs/reference_specs/WS-REV-001-review-lifecycle-specification.pdfis excluded by!**/*.pdf
📒 Files selected for processing (37)
.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CHUNK_MAP.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CONFORMANCE_MATRIX.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CON_INTEGRATION_REVIEW.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DECISIONS.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DISCOVERY.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/INTENT.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/PLAN.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/REVIEW_LOG.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/RISKS.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/SOURCE_MANIFEST.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/STATUS.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-01-canonical-contract-adoption.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-02-review-policy-task-alignment.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-03-review-queue-lease-persistence.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-04-review-chain-persistence.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-05-checker-routing-queue-views.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-06-claims-preference-timers.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-07-review-context-finding-evidence.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-08-immutable-decision-kernel.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-09A-revision-context-resubmission.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-09B-finding-replay-resolution-routing.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-10-contribution-integration-hidden-composition.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-11-admin-revocation-reconciliation.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-12-projection-observability.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-12A-joint-lifecycle-release-control.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-13-live-drill-docs-release.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-PLAN-review-revision-lifecycle-planning.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-ART-02A2-dependency-review.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-AUTH-07B-dependency-review.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-AUTH-08-dependency-review.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN-internal-review-evidence.md.agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN-pr-trust-bundle.md.agent-loop/merge-intents/WS-REV-001-PLAN.json.gitattributesdocs/reference_specs/README.mddocs/reference_specs/SHA256SUMSdocs/reference_specs/WS-REV-001-review-lifecycle-specification.md
🚧 Files skipped from review as they are similar to previous changes (17)
- .agent-loop/merge-intents/WS-REV-001-PLAN.json
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-PLAN-review-revision-lifecycle-planning.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CONFORMANCE_MATRIX.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CON_INTEGRATION_REVIEW.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-11-admin-revocation-reconciliation.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/SOURCE_MANIFEST.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-01-canonical-contract-adoption.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-12-projection-observability.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/CHUNK_MAP.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-04-review-chain-persistence.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-06-claims-preference-timers.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/DISCOVERY.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-08-immutable-decision-kernel.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/chunks/WS-REV-001-02-review-policy-task-alignment.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/INTENT.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/STATUS.md
- .agent-loop/initiatives/WS-REV-001-review-revision-lifecycle/reviews/WS-REV-001-PLAN-pr-trust-bundle.md
PR Trust Bundle: WS-REV-001-PLAN
Chunk
WS-REV-001-PLAN- Review And Revision Lifecycle PlanningGoal
Reconcile the revised review/revision specification with trusted
mainandpublish an executable, dependency-aware implementation plan without changing
runtime behavior.
Human-Approved Intent
On 2026-07-15 the human approved D6 limit/deadline behavior, reviewer-current
work precedence, coherent joint lifecycle activation, the proposed chunk
sequence, and publication of this planning chunk. The approval does not start
WS-REV-001-01; that remains a separate post-merge decision.What Changed
permission, and 57-action contracts plus the later AUTH-owned 57-to-61
action-parity gate.
SQL error mapping, and canonical verification-timestamp blockers; retained
them as REV consumer regression invariants.
code or treating uncommitted sibling work as merged contracts.
preparation only, explicitly excluding ART scratch/source implementation from
REV and retaining later ART product capability gates.
command matrix, typed drain observations, callback/dispatch fencing, and
remote provider-I/O handoff requirements.
can proceed as separately approved, reviewable units.
Why It Changed
Trusted
mainnow contains AUTH-08, the shared ADR-0014 adapter foundation, andART-02A2 committed-source/local-preparation foundation.
The plan needed exact canonical identities, action accounting, integration
ownership, and an operable joint activation/shutdown contract before runtime
work could safely begin.
Design Chosen
The plan retains one task-bound Project Guide context, ART-mediated immutable
submission evidence, AUTH-owned authorization/action catalogues, CON-owned
contribution effects, and PostgreSQL-canonical joint lifecycle control. Remote
provider calls occur outside database transactions and lifecycle locks, with
durable fenced finalization.
Alternatives Rejected
rejectdecisions at revision limits or deadlines.Scope Control
Only the initiative planning tree, its single existing merge intent, and the
exact canonical WS-REV reference filename/checksum repair are in scope. No
backend, active product documentation, dependency, migration, or runtime
behavior changes are included.
Product Behavior
None changes in this chunk. It defines future contracts for
accept,needs_revision, andreject, guide rebase, evidence disclosure, reviewerleases, contribution effects, shutdown, recovery, and activation.
Acceptance Criteria Proof
The source manifest records Markdown/PDF provenance; discovery maps current
subsystem boundaries; decisions and risks separate approved behavior from hard
dependency gates; the conformance matrix covers specification sections
25.1-25.9; every proposed chunk has bounded scope and verification; and the
single merge intent names
WS-REV-001-01with explicit-start required.Tests/Checks Run
The historical evidence binding is replaced only after the final merged-ART
planning snapshot receives all required internal reviewers. The evidence-only
publication commit then binds that exact reviewed code SHA and must make
check_internal_review_evidence.pypass before push.The AUTH/REV accounting check proves 74 PermissionIds and 57 registered
ActionIds split into 9 active actions and 48 planned actions. All 20 existing
revised-spec actions are present but planned, four additive actions are absent
and gated, and all 24 WS-REV dependencies are inactive. The four later REV
additions require exact 57-to-61 parity and produce 9 active and 52 planned
while all 24 dependencies remain inactive until their owning chunks.
AUTH-08 merged through PR #131 at trusted-main
aa0fdcd6912e66609e39a2fbd7b65f67be6c62f3, final branch head0832358a0262805f553d05b50b0d778e6e6ad995. Its evidence records 275 focusedbehavior tests, 90.17 percent branch-aware focused coverage, 17 isolated
Alembic tests, and green final Backend, Agent Gates, and CodeRabbit checks.
ART-02A2 merged through PR #129 at trusted-main
9a04434e2f23c5dec8939dadb943bba4d85110c0, final branch head32aab89262a3944f305e9e5dc4c65a2d31e2e144. Its evidence records 154 focusedtests at 94.40 percent scoped coverage, 38 isolated artifact PostgreSQL tests,
207 isolated AUTH/authentication/Alembic tests, and green final Backend, Agent
Gates, and CodeRabbit checks. Active ArtifactStore v1 remains unchanged.
Test Delta
No product tests change because this is a planning-only chunk. Repository policy
and evidence-gate tests are rerun against the publication commits.
CI Integrity
No workflows, package scripts, test thresholds, skips, coverage settings, or
merge controls change.
Reviewer Results
Historical PLAN and AUTH-08 refresh reviews remain durable evidence. The final
merged-ART planning snapshot receives senior engineering, QA/test,
security/auth, product/ops, architecture, docs, and reuse/dedup review before
its exact code SHA is bound in the internal-review evidence.
Final exact-snapshot results: senior engineering/architecture/reuse passed with
low risks; QA/test and product/ops passed; security/auth, docs, and CI integrity
passed after the provider-state wording repair. Reviewed code SHA is
cce3884033a187d40b9a8ae67af8163098e19318; detailed results and reviewer IDsare recorded in
WS-REV-001-PLAN-internal-review-evidence.md.External Review
The merged-dependency revision passed Backend, Agent Gates, and CodeRabbit.
Thread-aware audit then found eight actionable planning-contract comments; all
eight were repaired with no deferral. Exact dispositions are recorded in
WS-REV-001-PLAN-external-review-response.md. The repaired code snapshotpassed refreshed internal review and exact-SHA evidence binding. Fresh external
checks are required on the published repair before human merge.
Remaining Risks
AUTH, ART, CON, shared-outbox, digest/context, compensation, drain-observation,
and dispatch/callback contracts remain hard merged-SHA gates at their owning
chunks. Joint lifecycle activation remains Operator-controlled and cannot occur
until recovery, operations, and live-drill proof are complete.
REV runtime consumers must preserve AUTH-08's rollback-only dependency teardown,
typed authorization-evidence
503mapping, and route-owned canonicalverification-timestamp behavior. Missing or regressed proof blocks activation.
Follow-Up Work
After this PR merges, a human may separately activate
WS-REV-001-01. Eachsuccessor chunk requires its own contract, dependency refresh, implementation,
evidence, reviewer fanout, and merge approval.
Human Review Focus
Review D6 behavior, Project Guide authority/rebase, reviewer-current precedence,
AUTH action parity, ART/CON ownership boundaries, joint lifecycle fencing, and
the fact that no runtime chunk is activated by this PR.
Human Merge Ownership
Only the human may approve and merge this PR. The agent stops after publication
and does not start the successor automatically.