Preserve custom distribution subclasses in conversion factories - #5357
Draft
FlorianPfaff wants to merge 6 commits into
Draft
Preserve custom distribution subclasses in conversion factories#5357FlorianPfaff wants to merge 6 commits into
FlorianPfaff wants to merge 6 commits into
Conversation
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix five custom-distribution conversion factories so the target-centric
convert_distribution(source, TargetSubclass)API returns the requested subclass instead of silently constructing the base representation.Affected targets:
CustomLinearDistributionCustomHypercylindricalDistributionCustomHypersphericalDistributionCustomHyperhemisphericalDistributionCustomHemisphericalDistributionRoot cause
convert_distributionresolvesTargetSubclass.from_distribution(...). These inherited factories werestaticmethods and explicitly constructed their base class, so subclass-based extensions lost their concrete target type. This is the same factory-contract issue fixed for several Dirac/grid targets in #5347, but the custom-distribution factories were still affected.Fix
classmethodscls(...)convert_distributiongateway for all five target familiesValidation
mainatbaac3b1736bb8e81eafc1e3f69e10104636103b9