Skip to content

Reject scalar hypersphere uniform pdf inputs cleanly#3704

Merged
FlorianPfaff merged 2 commits into
mainfrom
bugfix/hyperspherical-scalar-shape
Jul 2, 2026
Merged

Reject scalar hypersphere uniform pdf inputs cleanly#3704
FlorianPfaff merged 2 commits into
mainfrom
bugfix/hyperspherical-scalar-shape

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Guard rank-0 hypersphere uniform pdf inputs before reading shape[-1].
  • Add a regression test showing scalar inputs now raise the intended ValueError instead of leaking IndexError.

Bug fixed

AbstractHypersphereSubsetUniformDistribution.pdf() accessed xs.shape[-1] unconditionally. For scalar inputs such as 1.0, NumPy arrays have shape (), so the validator raised IndexError before PyRecEst could report the documented invalid-shape ValueError.

Validation

  • Inspected main..bugfix/hyperspherical-scalar-shape: 2 files changed, +18/-1.
  • Added tests/distributions/test_hypersphere_uniform_scalar_pdf.py.
  • Full tests were not run locally because this execution environment cannot resolve github.com for cloning/installing the repository.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 2, 2026 18:03
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 57.97s
✅ JSON prettier 7 0 0 0 0.95s
✅ JSON v8r 7 0 0 3.43s
✅ MARKDOWN markdownlint 68 0 0 0 1.16s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.34s
✅ PYTHON black 1204 35 0 0 46.59s
✅ PYTHON isort 1204 68 0 0 2.6s
✅ REPOSITORY checkov yes no no 37.78s
✅ REPOSITORY gitleaks yes no no 9.43s
✅ REPOSITORY git_diff yes no no 0.16s
✅ REPOSITORY secretlint yes no no 34.08s
✅ REPOSITORY syft yes no no 3.69s
✅ REPOSITORY trivy-sbom yes no no 5.33s
✅ REPOSITORY trufflehog yes no no 13.95s
✅ YAML prettier 11 0 0 0 0.5s
✅ YAML v8r 11 0 0 7.78s
✅ YAML yamllint 11 0 0 0.34s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit cd5472f into main Jul 2, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant