Skip to content

Support PyTorch triangular helpers for array-like inputs#3646

Open
FlorianPfaff wants to merge 1 commit into
mainfrom
pyrecest-triangular-arraylike-current
Open

Support PyTorch triangular helpers for array-like inputs#3646
FlorianPfaff wants to merge 1 commit into
mainfrom
pyrecest-triangular-arraylike-current

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Patch raw PyTorch vec_to_diag, tril_to_vec, and triu_to_vec so they coerce array-like inputs through the backend array constructor.
  • Keep public PyTorch backend helpers synchronized when PyTorch is the active backend.
  • Move generated triangular indices onto the input tensor device before indexing.

Bug fixed

The raw PyTorch triangular-vector helpers assumed tensor inputs: vec_to_diag([1.0, 2.0]) passed a Python list to torch.diag_embed, while tril_to_vec([[...]]) and triu_to_vec([[...]]) accessed .shape on a list. CUDA tensors could also be indexed with CPU-generated triangular indices. The wrapper normalizes inputs and index devices.

Validation

  • Inspected the branch diff against current main.
  • Full test suite was not run because the repository could not be cloned in this environment.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 71.69s
✅ JSON prettier 7 0 0 0 1.06s
✅ JSON v8r 7 0 0 5.06s
✅ MARKDOWN markdownlint 68 0 0 0 1.62s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.67s
✅ PYTHON black 1185 29 0 0 57.53s
✅ PYTHON isort 1185 52 0 0 3.28s
✅ REPOSITORY checkov yes no no 44.98s
✅ REPOSITORY gitleaks yes no no 11.48s
✅ REPOSITORY git_diff yes no no 0.23s
✅ REPOSITORY secretlint yes no no 43.67s
✅ REPOSITORY syft yes no no 5.52s
✅ REPOSITORY trivy-sbom yes no no 5.54s
✅ REPOSITORY trufflehog yes no no 16.63s
✅ YAML prettier 11 0 0 0 0.66s
✅ YAML v8r 11 0 0 10.56s
✅ YAML yamllint 11 0 0 0.49s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 1, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant