Skip to content

Support float16 aliases in PyTorch as_dtype#3642

Open
FlorianPfaff wants to merge 1 commit into
mainfrom
fix-pytorch-as-dtype-float16-20260701
Open

Support float16 aliases in PyTorch as_dtype#3642
FlorianPfaff wants to merge 1 commit into
mainfrom
fix-pytorch-as-dtype-float16-20260701

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Add float16 to the PyTorch backend dtype alias map.
  • Make backend.as_dtype("float16"), backend.as_dtype(np.dtype("float16")), and the raw PyTorch backend equivalent resolve to torch.float16 instead of raising KeyError.

Bug fixed

The PyTorch backend already normalizes float16 aliases in lower-level array creation through _common._normalize_dtype, but _dtype.as_dtype used a narrower MAP_DTYPE that omitted float16. That made the public as_dtype backend API reject a valid dtype alias that other PyTorch backend paths accepted.

Validation

  • Confirmed the branch diff only changes src/pyrecest/_backend/pytorch/_dtype.py (+2/-0).
  • Attempted to add a focused backend regression, but the GitHub connector safety layer blocked writes under tests/backend_support in this session.
  • Full test suite not run locally because the execution environment cannot resolve github.com for cloning.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 69.35s
✅ JSON prettier 7 0 0 0 1.09s
✅ JSON v8r 7 0 0 4.85s
✅ MARKDOWN markdownlint 68 0 0 0 1.65s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.76s
✅ PYTHON black 1185 29 0 0 65.42s
✅ PYTHON isort 1185 52 0 0 5.25s
✅ REPOSITORY checkov yes no no 50.95s
✅ REPOSITORY gitleaks yes no no 10.53s
✅ REPOSITORY git_diff yes no no 0.17s
✅ REPOSITORY secretlint yes no no 44.68s
✅ REPOSITORY syft yes no no 4.39s
✅ REPOSITORY trivy-sbom yes no no 7.36s
✅ REPOSITORY trufflehog yes no no 18.53s
✅ YAML prettier 11 0 0 0 0.77s
✅ YAML v8r 11 0 0 10.83s
✅ YAML yamllint 11 0 0 0.61s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 1, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant