Skip to content

Fix PyTorch binary scalar boxing device placement#3639

Open
FlorianPfaff wants to merge 3 commits into
mainfrom
fix-pytorch-binary-scalar-device-boxing-20260701
Open

Fix PyTorch binary scalar boxing device placement#3639
FlorianPfaff wants to merge 3 commits into
mainfrom
fix-pytorch-binary-scalar-device-boxing-20260701

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Preserve an existing tensor placement when PyTorch binary scalar wrappers box Python/list operands.
  • Move already boxed tensor operands to the selected placement before calling the underlying PyTorch binary operation.
  • Add a backend regression covering the non-CPU tensor operand path.

Bug fixed

The previous wrapper implementation materialized Python/list operands with plain torch.tensor(...). That could put the newly boxed operand somewhere different from an existing tensor operand, causing binary operations such as arctan2 to fail with a placement mismatch.

Validation

  • Syntax-checked the changed module and regression test locally with py_compile.
  • Reproduced the old placement mismatch locally and verified that the patched boxing path returns a result with the expected shape and placement.
  • Full repository suite not run locally because direct repository cloning is unavailable in this execution environment.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 81.44s
✅ JSON prettier 7 0 0 0 1.79s
✅ JSON v8r 7 0 0 4.64s
✅ MARKDOWN markdownlint 68 0 0 0 1.95s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.83s
✅ PYTHON black 1185 29 0 0 68.12s
✅ PYTHON isort 1185 52 0 0 6.39s
✅ REPOSITORY checkov yes no no 52.54s
✅ REPOSITORY gitleaks yes no no 10.4s
✅ REPOSITORY git_diff yes no no 0.32s
✅ REPOSITORY secretlint yes no no 43.19s
✅ REPOSITORY syft yes no no 5.51s
✅ REPOSITORY trivy-sbom yes no no 6.43s
✅ REPOSITORY trufflehog yes no no 20.89s
✅ YAML prettier 11 0 0 0 0.8s
✅ YAML v8r 11 0 0 12.04s
✅ YAML yamllint 11 0 0 0.56s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 1, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant