Skip to content

Fix PyTorch comparison device contract#3633

Open
FlorianPfaff wants to merge 1 commit into
mainfrom
fix-pytorch-comparison-device-contract-v2
Open

Fix PyTorch comparison device contract#3633
FlorianPfaff wants to merge 1 commit into
mainfrom
fix-pytorch-comparison-device-contract-v2

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Extend the PyTorch backend support device-placement hook to cover greater, less, and logical_or.
  • Prefer an existing non-CPU tensor device before delegating to the underlying helper, matching the existing logical/equality device contract behavior.
  • Keep raw PyTorch backend and active public PyTorch backend helpers synchronized when the patch is applied.

Bug fixed

The package initializer already wrapped greater, less, and logical_or, but that wrapper picked the first tensor operand's device. Calls with a CPU tensor on the left and a CUDA/meta tensor on the right could therefore try to move the right operand back to CPU or evaluate mixed-device operands, unlike the newer backend-support hooks that prefer existing non-CPU devices.

Validation

  • Syntax-checked the updated module content locally with py_compile.
  • Smoke-checked the device-selection wrapper logic locally with PyTorch CPU-left/meta-right operands for greater, less, and logical_or.
  • Full suite not run in this environment because direct repository cloning is unavailable.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 79.59s
✅ JSON prettier 7 0 0 0 0.97s
✅ JSON v8r 7 0 0 5.46s
✅ MARKDOWN markdownlint 68 0 0 0 1.81s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.78s
✅ PYTHON black 1183 29 0 0 69.1s
✅ PYTHON isort 1183 51 0 0 5.45s
✅ REPOSITORY checkov yes no no 52.81s
✅ REPOSITORY gitleaks yes no no 9.91s
✅ REPOSITORY git_diff yes no no 0.28s
✅ REPOSITORY secretlint yes no no 40.33s
✅ REPOSITORY syft yes no no 4.69s
✅ REPOSITORY trivy-sbom yes no no 9.84s
✅ REPOSITORY trufflehog yes no no 21.07s
✅ YAML prettier 11 0 0 0 0.77s
✅ YAML v8r 11 0 0 12.94s
✅ YAML yamllint 11 0 0 0.57s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 1, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant