Skip to content

Fix scalar Gaussian log-pdf backend shape#3620

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-gaussian-scalar-ln-pdf
Open

Fix scalar Gaussian log-pdf backend shape#3620
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-gaussian-scalar-ln-pdf

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • preserve scalar output shape for one-dimensional GaussianDistribution.ln_pdf scalar inputs after PyTorch/JAX event-dimension reshaping
  • keep one-dimensional array inputs as a batch of scalar evaluation points
  • add a backend-portable regression covering scalar ln_pdf, scalar pdf, and one-element batch ln_pdf across NumPy, PyTorch, and JAX

Bug fixed

For a one-dimensional Gaussian, scalar inputs are valid evaluation points. The NumPy/SciPy path returns a scalar log-density, but the PyTorch and JAX paths reshape scalar inputs to (-1, 1) for their multivariate-normal APIs and previously returned the resulting length-1 batch unchanged. The fix records scalar input shape before reshaping and reshapes the returned log-density back to ().

Validation

  • python -m py_compile src/pyrecest/distributions/nonperiodic/gaussian_distribution.py tests/backend_support/test_gaussian_scalar_logpdf_contract.py
  • Checked the underlying NumPy/PyTorch/JAX scalar-shape behavior in an isolated local snippet.
  • Full repository tests were not run locally because this environment could not clone/resolve github.com; CI should run the backend-portable regression.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 1, 2026 19:26
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 53.64s
✅ JSON prettier 7 0 0 0 0.7s
✅ JSON v8r 7 0 0 4.0s
✅ MARKDOWN markdownlint 68 0 0 0 1.34s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.65s
✅ PYTHON black 1175 26 0 0 45.89s
✅ PYTHON isort 1175 44 0 0 3.07s
✅ REPOSITORY checkov yes no no 37.59s
✅ REPOSITORY gitleaks yes no no 9.23s
✅ REPOSITORY git_diff yes no no 0.22s
✅ REPOSITORY secretlint yes no no 26.81s
✅ REPOSITORY syft yes no no 3.5s
✅ REPOSITORY trivy-sbom yes no no 9.31s
✅ REPOSITORY trufflehog yes no no 15.24s
✅ YAML prettier 11 0 0 0 0.56s
✅ YAML v8r 11 0 0 9.22s
✅ YAML yamllint 11 0 0 0.37s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant