Rework docs - #265
Conversation
Delete docs written for internal use before Proof shipped: - docs/edit-file-see-query-update-demo.md: issue #158 repro harness - docs/experiments/: starter benchmarks, issue drafts, DAG fixtures - docs/research/: internal research methodology Keep the six end-user docs (glossary, positioning, pmf-decision-rubric, data-ownership, json-export, local-dev-loop). Fix the one inbound link in examples/nextjs/README.md that pointed at the removed demo walkthrough. Change-Id: Ia4a82d15c61a4f142b542840f048e3f6912e6f35 Co-authored-by: Erika Ruth Witt <erikawitt@users.noreply.github.com>
Rename docs/pmf-decision-rubric.md to docs/comparison.md so the filename
matches its user-facing title.
Rewrite language that read as internal marketing or roadmap notes:
- comparison.md: replace the 'What to emphasize' sales-enablement table
('If someone is comparing Flatbread with... Explain that Flatbread
offers...') with a user-facing 'When to choose Flatbread' table that
addresses the reader directly. Tighten the intro.
- glossary.md: drop internal roadmap notes ('future ID work should...',
'Near-term validation work should...', 'Any future generated TypeScript
reader...'). State current validation behavior. Update the See-also
link to comparison.md.
- positioning.md: update the comparison link to comparison.md.
- data-ownership.md: replace 'portability story starts with a simple
constraint' with 'portability rests on one constraint'; replace
'relational integrity work' with 'validated content graph'; drop the
'prototype' hedge on the generated read API.
- json-export.md: drop 'A future option may strip _path / _filename...'
and 'do not yet have a stable flat representation' roadmap language.
- local-dev-loop.md: drop the 'prototype' hedge on the generated read API.
Change-Id: I2eecee9e8e93617862d609359558b773901dc544
Co-authored-by: Erika Ruth Witt <erikawitt@users.noreply.github.com>
After trimming internal docs and renaming pmf-decision-rubric.md to comparison.md, three tracked files still pointed at the old paths: - flatbread-flow-pmf-audit.md: update rubric link to ./docs/comparison.md. - flatbread-search-and-memory-research.md: drop the broken link to the deleted docs/research/performant-context-search/README.md (methodology dossiers were never checked in; reword to state that). - .flatbread-proof/findings/fnd-pmf-rubric-understates...: update the evidence citation path from docs/pmf-decision-rubric.md to docs/comparison.md so the citation resolves. Claim substance unchanged. Verified no remaining repo-wide references to edit-file-see-query-update-demo, docs/experiments, docs/research, pmf-decision-rubric, performant-context-search, or any individual deleted experiment file. All kept docs internal links and external README links resolve to existing files. Change-Id: I6e4e61f4463c90436b91502b5af634942aabc025 Co-authored-by: Erika Ruth Witt <erikawitt@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Move the four root-level internal research/playbook dossiers out of the repo front door into internal/: - flatbread-flow-pmf-audit.md (PMF audit) - flatbread-search-and-memory-research.md (search/memory research) - flatbread-agent-artifact-opportunity.md (agent-artifact opportunity) - flatbread-flow-agentic-workflows.md (agentic workflows playbook) These are internal strategy dossiers the agent harness uses as living alignment references, not end-user docs. The root now holds only user-facing files (README, AGENTS, CONTRIBUTING, CHANGELOG). Moving all four together keeps their mutual cross-links intact (intra-directory bare links still resolve). Add internal/README.md marking the directory as internal, not end-user docs, and pointing end-users back to docs/ and the root README. Fix the two .cursor/ config references that point at these files: - .cursor/agents/flatbread-architecture-planner.md - .cursor/skills/flatbread-major-migration/SKILL.md No end-user-facing file referenced the dossiers, so no other fixes needed. Change-Id: I6d68fa292030f38cff948a3b46a3604069311010 Co-authored-by: Erika Ruth Witt <erikawitt@users.noreply.github.com>
The agent harness should not anchor to the PMF audit: it self-declares as
a May 2026 stale snapshot ('background research, not current setup
instructions'). The search-and-memory and agent-artifact dossiers are
one-time research with no live agent-harness wiring. Only the
agentic-workflows playbook is current and referenced by the harness
(architecture-planner alignment + major-migration DAG topology).
- Delete internal/flatbread-flow-pmf-audit.md
- Delete internal/flatbread-search-and-memory-research.md
- Delete internal/flatbread-agent-artifact-opportunity.md
- .cursor/agents/flatbread-architecture-planner.md: drop the stale
PMF-audit anchor; keep the playbook reference.
- internal/flatbread-flow-agentic-workflows.md: reword line 3 to not
name the deleted PMF audit file.
- internal/README.md: list only the playbook.
This also clears the ~13 root-relative markdown links my prior move had
broken inside the three deleted dossiers. The playbook has no broken
markdown links (its package references are code spans, not links).
Change-Id: I348fff27ee55e1e35ea1530534a1e79f3dfea16a
Co-authored-by: Erika Ruth Witt <erikawitt@users.noreply.github.com>
There was a problem hiding this comment.
Stale comment
Verdict
REQUEST_CHANGES — the path-only Proof finding now states false facts about
docs/comparison.md.Prior notes
None. This PR had no earlier automation threads.
Domain verdicts
- Architecture: COMMENT
- Quality: COMMENT
- Proof journal: REQUEST_CHANGES
- Correctness: COMMENT (same HIGH on the stale finding)
What is fine
docs/is now six end-user pages. GraphQL stays one read interface.- Deleted paths have no remaining live refs.
- Glossary ID/validation, export, and watch claims match
packages/core(ids.ts,validate.ts, export JSON, watch coordinator).- No new Decision is required for the
docs/vsinternal/split.internal/README.mdalready states it, so unique signal fails.- Path retarget of the finding is allowed. There is no rename-citation mutation.
Required
Close
fnd-pmf-rubric-understates-shipped-validation-and-wa--p04gd8xfknwvz2pe. This PR already did the refresh the Implication asked for:docs/comparison.mdrates local development Medium–Strong withflatbread start --watch, and configuredrefsStrong with pre-schema checks. The finding still says the opposite.Write a Finding on
eff-relational-content-foundation--8a8332x4cazgf2k0that the comparison page now matches shipped watch and validation, thenSupersedethis record. UseInvalidateonly if you treat the current sentences as wrong rather than obsolete.Held
- Root and
packages/flatbreadREADMEs still omitdocs/comparison.md(those files are not in this diff).examples/nextjs/README.mdstill calls the generated read API a prototype (those lines are not in the hunk).internal/flatbread-flow-agentic-workflows.mdstill opens as a PMF-audit execution workflow after that dossier was deleted.Models
- Architecture, proof, correctness: inherit (latest Cursor Grok)
- Quality:
composer-2.5- Oven missing; Task fallback
Sent by Cursor Automation: Flatbread PR Review
Write a Finding that the comparison page now matches shipped watch and configured-ref validation, then supersede the old rubric claim. Addresses review on #265. Change-Id: Ide3d5bd592a8fe51c109503fb3ef38131b592b44 Co-authored-by: Erika Ruth Witt <erikawitt@users.noreply.github.com>
Change-Id: I6db72a9f8455256f2800d171cc1947dd1c2ae94f Co-authored-by: Erika Ruth Witt <erikawitt@users.noreply.github.com>
There was a problem hiding this comment.
Verdict
APPROVE — the stale comparison Finding is superseded. Kept docs match shipped watch and validation.
Prior notes
Closed the earlier request on fnd-pmf-rubric-understates-shipped-validation-and-wa--p04gd8xfknwvz2pe. New Finding fnd-comparison-page-now-matches-shipped-watch-and-va--bkat8y0abty4pvcz supersedes it on eff-relational-content-foundation--8a8332x4cazgf2k0. The old body stays as history. That is the right edge.
Domain verdicts
- Architecture: APPROVE
- Quality: COMMENT (wording only; no blocker)
- Proof journal: APPROVE
- Correctness: APPROVE
What is fine
docs/is six end-user pages. GraphQL stays one read interface.- Deleted paths have no remaining live refs. The playbook no longer cites
flatbread-flow-pmf-audit.md. - Glossary ID/validation, export, and watch claims match
packages/core(ids.ts,validate.ts, export JSON, watch coordinator) andflatbread start --watch. - The new Finding scores 4/4. Typed
WriteFinding+Supersede; back-edge is materialized. No extra Decision is needed for thedocs/vsinternal/split.
Optional
examples/nextjs/README.mdnow says “Restore the files after withpnpm run demo:restore.” Prefer “Afterward, restore the files with…”.internal/README.mdcalls the playbook schema-migration guidance; the playbook also covers docs, CLI, and release gates.
Held
- Root and
packages/flatbreadREADMEs still omitdocs/comparison.md(those files are not in this diff). examples/nextjs/README.mdstill calls the generated read API a prototype (those lines are not in the hunk).- The playbook opening still says “the PMF audit.” The file link is gone, and
dag-flatbread-flow-pmf-audit.jsonstill exists.
Models
- Architecture, proof, correctness: inherit (latest Cursor Grok)
- Quality:
composer-2.5 - Oven missing; Task fallback
Sent by Cursor Automation: Flatbread PR Review


What changed
pmf-decision-rubric.md→comparison.md; rewrote internal-staff language for end-users.What's gone
docs/edit-file-see-query-update-demo.md— issue Ship edit-file-see-query-update demo #158 repro harness, not the productionflatbread startpath.docs/experiments/— starter benchmarks (Benchmark canonical starter path to first typed read result #162), TS safety tests (Run TypeScript safety interview/test #163), export-trust (Run export trust self-review demo #164), Effort-Graph layout (Document representative Effort Graph reference-layout mapping #167), adversarial schema (Document three-layout Effort Graph schema mapping #168), retrieval benchmark (Benchmark representative artifact-byte reduction for blocking-decision retrieval #169), plus DAG fixtures and issue drafts.docs/research/performant-context-search/— internal/proofDAG methodology README.~1,200 lines removed.
What's kept (6 end-user docs)
glossary.mdpositioning.mdcomparison.mddata-ownership.mdjson-export.mdexportCollectionsAsJson/exportCollectionsAsCsvAPIlocal-dev-loop.mdflatbread start --watchbehavior, reload matrix, limitsLanguage rewritten (staff → user)
comparison.md: the "What to emphasize" sales-enablement table ("If someone is comparing Flatbread with… Explain that Flatbread offers…") → "When to choose Flatbread" ("If you are coming from… Flatbread gives you…").glossary.md: dropped roadmap notes ("future ID work should…", "Near-term validation work should…", "Any future generated TypeScript reader…"); states current validation behavior.data-ownership.md: "portability story starts with a simple constraint" → "portability rests on one constraint"; "relational integrity work" → "validated content graph"; dropped the "prototype" hedge.json-export.md: dropped "A future option may…" and "do not yet have a stable flat representation".local-dev-loop.md: "prototype read API" → "read API".Dangling refs fixed
flatbread-flow-pmf-audit.md→ rubric link now./docs/comparison.md.flatbread-search-and-memory-research.md→ removed broken links to deleteddocs/research/performant-context-search/README.md; reworded (dossiers were never checked in)..flatbread-proof/findings/fnd-pmf-rubric-understates…→ citation pathpmf-decision-rubric.md→comparison.md. Path-only fix; claim unchanged. Flagging because Proof records normally use typed mutations — there is no rename-citation mutation, so I edited the file directly.examples/nextjs/README.md→ "Full walkthrough" link to the deleted demo doc replaced with the existingdemo:restoreinstruction.Why
Many docs were written for internal use before Proof shipped. End-users reading
docs/hit benchmarks, issue drafts, and sales-enablement language. This keeps only what helps a user install, understand, and decide.How to review
Fast path: skim the diffstat (mostly deletions), then read
docs/comparison.mdanddocs/glossary.mdin full — those carry the substantive rewrites. The other four kept docs only had a line or two changed each.Verification
pnpm lint:fix:fastclean;pretty-quick --stagedpassed each commit.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Does this introduce any non-backwards compatible changes?
Does this include any user config changes?