feat(terminal): delivered Ctrl+C signals to the foreground process group - #169
Merged
Conversation
Terminal control bytes were ordinary input, so a stuck foreground program could only be killed from another shell. The line discipline now intercepts INTR/QUIT/SUSP under a termios-tracked ISIG bit and signals the pty's or console's foreground group, which the shell assigns to each job while it is frozen between create and start. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
terminal::ERR collides with fs::ERR_NOENT, so console pgrp ioctl failures surfaced as ENOENT while the pty path reported EINVAL. And a pipeline failing after its first stage left the terminal's foreground on the dead job's group instead of restoring the shell's. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Made with Cursor