feat(signals): honored SA_RESTART for interrupted syscalls - #168
Merged
Conversation
Handlers installed through musl's signal() set SA_RESTART, so every interrupted blocking call surfaced a spurious EINTR. Restartable waits now return an internal ERESTARTSYS the delivery boundary rewinds for re-execution or converts to EINTR, and handled signals no longer wake elevated tasks that cannot deliver them. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit a9381c4. Configure here.
| case resource::ERR_NOENT: return syscall::ENOENT; | ||
| case resource::ERR_NOTDIR: return syscall::ENOTDIR; | ||
| case resource::ERR_INTR: return syscall::EINTR; | ||
| case resource::ERR_INTR: return syscall::ERESTARTSYS; |
There was a problem hiding this comment.
Connect restart fails after signal
High Severity · Logic Bug
Mapping socket ERR_INTR to ERESTARTSYS makes blocking connect restartable under SA_RESTART, but tcp_connect only accepts CLOSED sockets. An interrupt during the SYN_SENT wait leaves the socket in SYN_SENT, so the restarted call returns EINVAL instead of finishing the handshake. With musl signal() (which sets SA_RESTART), a signal during connect turns a normal interrupt into a hard failure.
Reviewed by Cursor Bugbot for commit a9381c4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Made with Cursor