feat(signals): added signal frame layout types - #165
Merged
Conversation
Handler delivery needs the kernel to write signal frames that musl handlers, the restorer, and rt_sigreturn all read back, so the per-arch rt_sigframe layouts are pinned by static_asserts before any delivery code. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 6507b1f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__restore_rttrampoline, andrt_sigreturnall read back, so the layouts are pinned before any delivery logic exists.rt_sigframe/ucontext/sigcontext/fpsimd_contexttypes with offsetstatic_asserts matching the musl ABI, including the 16-byte-alignment padding that places the AArch64uc_mcontextat 176.Made with Cursor