fix(experiments): audience card spacing and dark theme borders - #8494
fix(experiments): audience card spacing and dark theme borders#8494Zaimwa9 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe changes update experiment layout containers to use zero horizontal margins. Audience segment rows now use component-specific SCSS for sizing, spacing, borders, backgrounds, and remove-control positioning. Bootstrap’s border colour variable now references the default design-system border token. Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates experiment wizard spacing and dark-theme border styling without changing experiment data flow or controls. No current merge-blocking risk remains. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ private-cloud · depot-ubuntu-latest-16 — run #20317 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Failed testsfirefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise 🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20317 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #20317 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20317 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
docs/if required so people know about the feature.Changes
8px 16px), delete button no longer hugs the edge, review-step summary reuses the identical card..flex-columnmargin)..border*utilities now use the--color-border-defaulttoken, so borders follow the dark theme (experiment wizard, warehouse connection card).How did you test this code?
Manually in dark mode: experiment wizard Rollout and Review steps, warehouse connection card.
npm run lint, experiments unit tests pass.