Skip to content

fix(experiments): audience card spacing and dark theme borders - #8494

Open
Zaimwa9 wants to merge 1 commit into
mainfrom
fix/experiment-wizard-ui-polish
Open

fix(experiments): audience card spacing and dark theme borders#8494
Zaimwa9 wants to merge 1 commit into
mainfrom
fix/experiment-wizard-ui-polish

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Audience segment card: fixed padding (8px 16px), delete button no longer hugs the edge, review-step summary reuses the identical card.
  • Removed stray horizontal insets in the wizard steps and audience picker (legacy .flex-column margin).
  • Bootstrap .border* utilities now use the --color-border-default token, so borders follow the dark theme (experiment wizard, warehouse connection card).

How did you test this code?

Manually in dark mode: experiment wizard Rollout and Review steps, warehouse connection card. npm run lint, experiments unit tests pass.

@Zaimwa9
Zaimwa9 requested a review from a team as a code owner September 9, 2026 16:05
@Zaimwa9
Zaimwa9 requested review from kyle-ssg and removed request for a team September 9, 2026 16:05
@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Sep 9, 2026 4:06pm UTC
flagsmith-frontend-staging Ready Ready Preview Sep 9, 2026 4:06pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Sep 9, 2026 4:06pm UTC

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard fix labels Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8494 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8494 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8494 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8494 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8494 Finished ✅ Results

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 146c9686-cac5-4a91-82a8-1d8b8c02173e

📥 Commits

Reviewing files that changed from the base of the PR and between d16f911 and 7ecfcfd.

📒 Files selected for processing (8)
  • frontend/web/components/experiments/AudiencePicker/AudiencePicker.tsx
  • frontend/web/components/experiments/AudienceSegmentList/AudienceSegmentList.scss
  • frontend/web/components/experiments/AudienceSegmentList/AudienceSegmentList.tsx
  • frontend/web/components/experiments/steps/MeasurementStep.tsx
  • frontend/web/components/experiments/steps/ReviewStep.tsx
  • frontend/web/components/experiments/steps/RolloutStep.tsx
  • frontend/web/components/experiments/steps/SetupStep.tsx
  • frontend/web/styles/3rdParty/_bootstrap.scss

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The changes update experiment layout containers to use zero horizontal margins. Audience segment rows now use component-specific SCSS for sizing, spacing, borders, backgrounds, and remove-control positioning. Bootstrap’s border colour variable now references the default design-system border token.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7ecfc

This updates experiment wizard spacing and dark-theme border styling without changing experiment data flow or controls. No current merge-blocking risk remains.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
❌ private-cloud · depot-ubuntu-latest-16 — run #20317 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  1 minute, 9 seconds
commit  7ecfcfd
info  📦 Artifacts: View test results and HTML report
🔄 Run: #20317 (attempt 1)

Failed tests

firefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise
firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20317 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  39.4 seconds
commit  7ecfcfd
info  🔄 Run: #20317 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20317 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.2 seconds
commit  7ecfcfd
info  🔄 Run: #20317 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #20317 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  47.1 seconds
commit  7ecfcfd
info  🔄 Run: #20317 (attempt 1)

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants