refactor(code-help): escape snippets centrally instead of in source strings#8062
Draft
talissoncosta wants to merge 1 commit into
Draft
refactor(code-help): escape snippets centrally instead of in source strings#8062talissoncosta wants to merge 1 commit into
talissoncosta wants to merge 1 commit into
Conversation
Highlight now always escapes (dropped the preventEscape branch); MCPSnippet and CodeHelp no longer pass preventEscape. Code-help sources use raw JSX (<FlagsmithProvider>) instead of hand-escaped entities (<), so they're readable. Rendered output is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
front-end
talissoncosta
added a commit
that referenced
this pull request
Jul 21, 2026
Keep this PR theming-only. preventEscape removal + code-help source de-escaping move to #8062. Highlight keeps embedded + the de-nested getRawHtml (retaining preventEscape); escaping behaviour is unchanged here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Zaimwa9
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #8023 to keep that PR to theming only.
Changes
Escape code snippets centrally in
Highlightinstead of hand-escaping HTML entities in the source strings.Highlightalways escapes now (dropped thepreventEscapebranch).MCPSnippetandCodeHelpno longer passpreventEscape.<FlagsmithProvider>) instead of pre-escaped entities (<), so they read like real code.Highlightescapes at render, so the output is unchanged.How did you test this code?
Rendered the SDK code snippets (CodeHelp) and MCP snippet; confirmed tags like
<FlagsmithProvider>display correctly and syntax highlighting is intact, matching the previous output.