Skip to content

Fix #7983: Add EDGE_IDENTITY to allowed integration audit events #8059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srijantrpth wants to merge 3 commits into
base: main
Choose a base branch
from
+32 −0
Open

Fix #7983: Add EDGE_IDENTITY to allowed integration audit events #8059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09eff6f
Fix #7983: Add EDGE_IDENTITY to allowed integration audit events
srijantrpth Jul 21, 2026
b97fc8e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 21, 2026
cf1ffa8
Potential fix for pull request finding
srijantrpth Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/audit/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def track_only_feature_related_events(signal_function): # type: ignore[no-untyp
RelatedObjectType.FEATURE_STATE,
RelatedObjectType.SEGMENT,
RelatedObjectType.EF_VERSION,
RelatedObjectType.EDGE_IDENTITY,
]
return track_only(allowed_types)(signal_function)

Expand Down
31 changes: 31 additions & 0 deletions api/tests/unit/audit/test_unit_audit_signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,3 +596,34 @@ def test_send_feature_flag_went_live_signal__non_feature_state_instance__skips_s

# Then
mock_signal_send.assert_not_called()


def test_send_audit_log_event_to_grafana__edge_identity__calls_expected(
mocker: MockerFixture,
project: Project,
) -> None:
# Given
audit_log_record = AuditLog.objects.create(
project=project,
related_object_type=RelatedObjectType.EDGE_IDENTITY.name,
)
grafana_wrapper_mock = mocker.patch("audit.signals.GrafanaWrapper", autospec=True)
grafana_wrapper_instance_mock = grafana_wrapper_mock.return_value

grafana_config = GrafanaProjectConfiguration(base_url="test.com", api_key="test")
project.grafana_config = grafana_config

# When
send_audit_log_event_to_grafana(AuditLog, audit_log_record)

# Then
grafana_wrapper_mock.assert_called_once_with(
base_url=grafana_config.base_url,
api_key=grafana_config.api_key,
)
grafana_wrapper_instance_mock.generate_event_data.assert_called_once_with(
audit_log_record=audit_log_record
)
grafana_wrapper_instance_mock.track_event_async.assert_called_once_with(
event=grafana_wrapper_instance_mock.generate_event_data.return_value
)
Loading