-
Notifications
You must be signed in to change notification settings - Fork 551
feat(onboarding): funnel analytics for the new flow #7960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
talissoncosta
wants to merge
4
commits into
main
Choose a base branch
from
feat/onboarding-analytics-7738
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
30ffd6c
feat(onboarding): fire First Project/Feature milestone events from bo…
talissoncosta 2d1be40
feat(onboarding): add new-flow diagnostics events
talissoncosta c67bc32
feat(onboarding): tag onboarding_variant at the getting-started gate
talissoncosta df6090f
fix(onboarding): pick the arm from the flag's variant name
talissoncosta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import Utils from './utils' | ||
|
|
||
| export type OnboardingVariant = 'control' | 'single_page' | ||
|
|
||
| // The served variant name picks the arm ('control' is the reserved key the | ||
| // API reports for the default arm). Enabled with no variant is the | ||
| // pre-conversion boolean flag, which means the new flow. | ||
| export const isSinglePageOnboarding = (): boolean => | ||
| Utils.getFlagsmithHasFeature('onboarding_quickstart_flow') && | ||
| Utils.getFlagsmithVariant('onboarding_quickstart_flow') !== 'control' | ||
|
|
||
| export const getOnboardingVariant = (): OnboardingVariant => | ||
| isSinglePageOnboarding() ? 'single_page' : 'control' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 15 additions & 14 deletions
29
frontend/web/components/pages/onboarding/GettingStartedGate.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,20 @@ | ||
| import React, { FC } from 'react' | ||
| import Utils from 'common/utils/utils' | ||
| import React, { FC, useEffect } from 'react' | ||
| import { | ||
| getOnboardingVariant, | ||
| isSinglePageOnboarding, | ||
| } from 'common/utils/getOnboardingVariant' | ||
| import API from 'project/api' | ||
| import GettingStartedPage from 'components/pages/GettingStartedPage' | ||
| import OnboardingFlow from './OnboardingFlow' | ||
|
|
||
| // Gates /getting-started: renders the new onboarding flow when the | ||
| // `onboarding_quickstart_flow` flag is on, otherwise the existing page. | ||
| // | ||
| // Deliberately a flat file, not a folder + barrel - a one-line route gate with | ||
| // no styles or sub-parts, the documented exception to the component-folder | ||
| // convention (frontend/CLAUDE.md rule 8). | ||
| const GettingStartedGate: FC = () => | ||
| Utils.getFlagsmithHasFeature('onboarding_quickstart_flow') ? ( | ||
| <OnboardingFlow /> | ||
| ) : ( | ||
| <GettingStartedPage /> | ||
| ) | ||
| const GettingStartedGate: FC = () => { | ||
| const variant = getOnboardingVariant() | ||
|
|
||
| useEffect(() => { | ||
| API.trackTraits({ onboarding_variant: variant }) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tagged at the gate (only users who reach onboarding). |
||
| }, [variant]) | ||
|
|
||
| return isSinglePageOnboarding() ? <OnboardingFlow /> : <GettingStartedPage /> | ||
| } | ||
|
|
||
| export default GettingStartedGate | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.