feat(GitLab): Link GitLab issues and merge requests to feature flags by emyller · Pull Request #7274 · Flagsmith/flagsmith

emyller · 2026-04-17T00:19:11Z

I have read the Contributing Guide.
~~I have added information to docs/ if required so people know about the feature.~~
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Stack: #7270 (backend) → #7273 (frontend) → #7274 (this)

With browsing in place (#7270, #7273), users can now link GitLab issues and merge requests to their feature flags. This completes the core linking flow.

Slight refactor: <ExternalResourcesTable> now renders regardless of GitHub.

Review effort: 2/5

How did you test this code?

Integration tests. Manual UI tests. Screenshots:

vercel · 2026-04-17T00:19:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Apr 18, 2026 2:14am
flagsmith-frontend-preview	Ignored	Preview	Apr 18, 2026 2:14am
flagsmith-frontend-staging	Ignored	Preview	Apr 18, 2026 2:14am

codecov · 2026-04-17T00:57:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/gitlab-browse-frontend@c4a4307). Learn more about missing BASE report.

Additional details and impacted files

@@                      Coverage Diff                       @@
##             feat/gitlab-browse-frontend    #7274   +/-   ##
==============================================================
  Coverage                               ?   98.36%           
==============================================================
  Files                                  ?     1366           
  Lines                                  ?    51154           
  Branches                               ?        0           
==============================================================
  Hits                                   ?    50320           
  Misses                                 ?      834           
  Partials                               ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claude

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

github-actions · 2026-04-17T01:06:39Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-e2e:pr-7274`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api-test:pr-7274`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-7274`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7274`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7274`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-7274`	Finished ✅	Results ✅

github-actions · 2026-04-17T01:11:17Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

11 passed

Details

11 tests across 8 suites
45.1 seconds
a214ee7
🔄 Run: #16160 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

11 passed

Details

11 tests across 8 suites
30.5 seconds
a214ee7
🔄 Run: #16160 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
47.1 seconds
a214ee7
🔄 Run: #16160 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
59.2 seconds
a214ee7
🔄 Run: #16160 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

11 passed

Details

11 tests across 8 suites
39.8 seconds
8bf6b03
🔄 Run: #16180 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

11 passed

Details

11 tests across 8 suites
55.6 seconds
8bf6b03
🔄 Run: #16180 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
46.7 seconds
8bf6b03
🔄 Run: #16180 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 3 seconds
8bf6b03
🔄 Run: #16180 (attempt 1)

github-actions · 2026-04-17T01:13:07Z

Visual Regression

16 screenshots compared. See report for details.
View full report

khvn26 · 2026-04-17T15:00:39Z

+            "issue-linked",
+            project__id=feature.project_id,


Can use organisation__id here.

8bf6b03 — also fixed other GitLab logs since we're here.

khvn26

LGTM — again, just 1 comment.

Zaimwa9

Couple of mostly minor comments that should be quite straightforward 👍

Zaimwa9 · 2026-04-17T14:54:20Z

+    ) -> Response:
+        response = super().create(request, *args, **kwargs)
+        structlog.get_logger("gitlab").info(
+            "issue-linked",


Good to see but actually the naming should follow entity.action https://github.com/Flagsmith/flagsmith/pull/7268/changes#diff-c7b1c23e00a1fd0378f6ea41a7dfe1c9e043d766f738dba26860c783b82e8c6aR91

Same below

Should we add organisation Id ?

Agreed, thanks for pointing to guidance docs. 8bf6b03 — also fixed other recently added logs to meet guidelines.

Zaimwa9 · 2026-04-17T14:59:11Z

+        metadata: {
+          state: selectedItem.state,
+          title: selectedItem.title,
+          ...('merged' in selectedItem && { merged: selectedItem.merged }),
+          ...('draft' in selectedItem && { draft: selectedItem.draft }),


We are never passing iids ? cf backend related test

Zaimwa9 · 2026-04-17T15:02:06Z

+    }).then(() => {
+      toast('GitLab link added')
+      setSelectedItem(null)
+      AppActions.refreshFeatures(projectId, environmentId)
+    })


Same we'd need to catch error (and at the same time move to async/await 😄 )

Zaimwa9 · 2026-04-17T15:04:22Z

+        *args: Any,
+        **kwargs: Any,
+    ) -> Response:
+        response = super().create(request, *args, **kwargs)


It seems the payload has already been validated, so shouldn't it be a perform_create directly ?

github-actions bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API feature New feature or request labels Apr 17, 2026

This was referenced Apr 17, 2026

feat(GitLab): Browse GitLab issues and merge requests (backend) #7270

Merged

feat(GitLab): Browse GitLab issues and merge requests (frontend) #7273

Open

emyller changed the title ~~feat(GitLab): Link GitLab issues and MRs to feature flags~~ feat(GitLab): Link GitLab issues and merge requests to feature flags Apr 17, 2026

emyller force-pushed the feat/gitlab-link-issues-mrs-flow branch from 4a25c7e to 8c91bf3 Compare April 17, 2026 00:51

vercel bot deployed to Preview – flagsmith-frontend-staging April 17, 2026 00:52 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview April 17, 2026 00:52 View deployment

github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 17, 2026

emyller force-pushed the feat/gitlab-link-issues-mrs-flow branch from 8c91bf3 to a214ee7 Compare April 17, 2026 00:59

github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 17, 2026

vercel bot deployed to Preview – flagsmith-frontend-preview April 17, 2026 01:00 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging April 17, 2026 01:00 View deployment

emyller marked this pull request as ready for review April 17, 2026 01:05

emyller requested review from a team as code owners April 17, 2026 01:05

emyller requested review from Zaimwa9 and removed request for a team April 17, 2026 01:05

claude bot reviewed Apr 17, 2026

View reviewed changes

github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 17, 2026

khvn26 reviewed Apr 17, 2026

View reviewed changes

khvn26 approved these changes Apr 17, 2026

View reviewed changes

Zaimwa9 requested changes Apr 17, 2026

View reviewed changes

emyller added 3 commits April 17, 2026 21:01

Extract link management from GitHub coupling

b0d7a34

Complete the flow with actual linking

fabbaf5

Improve telemetry

8bf6b03

emyller force-pushed the feat/gitlab-link-issues-mrs-flow branch from a214ee7 to 8bf6b03 Compare April 18, 2026 02:14

github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 18, 2026

Conversation

emyller commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

vercel bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

github-actions bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

github-actions bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

khvn26 Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

emyller Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

khvn26 left a comment

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 left a comment

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

emyller Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

emyller commented Apr 17, 2026 •

edited

Loading

vercel bot commented Apr 17, 2026 •

edited

Loading

codecov bot commented Apr 17, 2026 •

edited

Loading

github-actions bot commented Apr 17, 2026 •

edited

Loading

github-actions bot commented Apr 17, 2026 •

edited

Loading

github-actions bot commented Apr 17, 2026 •

edited

Loading

emyller Apr 18, 2026 •

edited

Loading

Zaimwa9 Apr 17, 2026 •

edited

Loading