fix(codex): rewrite unsupported tool references#1133
Open
SIGMAREAL wants to merge 1 commit into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThis PR adds a transformer that converts Claude-style tool references into Codex-compatible instruction wording, applies it in the Codex command adapter, and wires tool-specific transformer selection into init, update, and workspace skill-generation flows. ChangesCodex tool reference transformation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/core/command-generation/adapters.test.ts (1)
324-334: ⚡ Quick winAdd one positive assertion for transformed semantics.
This test only checks removed tokens; it can still pass if the whole line is accidentally dropped. Add one expected replacement assertion (for example,
Ask the user in chat...) to lock behavior.✅ Minimal test hardening
expect(output).not.toContain('Task tool'); expect(output).not.toContain('subagent_type'); + expect(output).toContain('Ask the user in chat'); });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/core/command-generation/adapters.test.ts` around lines 324 - 334, The test "should replace unsupported runtime tool references" currently only asserts that unsupported tokens are removed; update the test that calls codexAdapter.formatFile with sampleContent to also assert a positive transformed phrase is present (e.g., add expect(output).toContain('Ask the user in chat') or similar) so the test verifies replacement semantics rather than just deletion; keep existing negative checks for 'AskUserQuestion', 'TodoWrite', 'Task tool' and 'subagent_type' and add one clear positive assertion referencing the expected transformed text produced by codexAdapter.formatFile.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/core/command-generation/adapters.test.ts`:
- Around line 324-334: The test "should replace unsupported runtime tool
references" currently only asserts that unsupported tokens are removed; update
the test that calls codexAdapter.formatFile with sampleContent to also assert a
positive transformed phrase is present (e.g., add expect(output).toContain('Ask
the user in chat') or similar) so the test verifies replacement semantics rather
than just deletion; keep existing negative checks for 'AskUserQuestion',
'TodoWrite', 'Task tool' and 'subagent_type' and add one clear positive
assertion referencing the expected transformed text produced by
codexAdapter.formatFile.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 84f7cfe3-11be-4be4-bf3b-aa1d913ea3a1
📒 Files selected for processing (7)
src/core/command-generation/adapters/codex.tssrc/core/init.tssrc/core/update.tssrc/core/workspace/skills.tssrc/utils/command-references.tstest/core/command-generation/adapters.test.tstest/utils/command-references.test.ts
SIGMAREAL
force-pushed
the
fix/codex-tool-reference-instructions
branch
from
b1124ea to
a51272d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
AskUserQuestion|TodoWrite|Task tool|subagent_typeNotes
pnpm testhas one environment-dependent existing failure locally:test/commands/artifact-workflow.test.ts > creates skills for Cursor toolexpects.cursor/commands/opsx-explore.md, but my global OpenSpec config isdelivery: skills, so that command file is not generated.Fixes #1103
Summary by CodeRabbit
New Features
Tests