Verify difference file path against DatabaseAccess#9089
Open
caolanm wants to merge 1 commit into
Open
Conversation
The difference file opened in openDelta and beginBackup was not verified against DatabaseAccess like the other database file paths.
Member
|
Hmm... why do you think difference file placement must be verified exactly this way, i.e. against |
Member
Not agree, sorry |
Author
|
LibreOffice, optionally, supports embedded firebird databases so we'd like to not allow arbitrary dbs, that a user might receive from someone else, to specify what file paths they backup to and the LibreOffice firebird save |
tdf-gerrit
pushed a commit
to LibreOffice/core
that referenced
this pull request
Jul 14, 2026
A database we extract from a .odb is always in the normal backup state, so refuse one that is not, we're not interested in the difference file mode case. firebird upstream attempt as: FirebirdSQL/firebird#9089 And do it manually for the system-firebird case. Change-Id: Iff9ebbb075379ca47a7f7f5886b693ac23860566 Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/6702 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CPCI <releng@collaboraoffice.com> (cherry picked from commit e7ea381e87cadaf31bf1ad2213a23f17a6284d1c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208040 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
tdf-gerrit
pushed a commit
to LibreOffice/core
that referenced
this pull request
Jul 14, 2026
A database we extract from a .odb is always in the normal backup state, so refuse one that is not, we're not interested in the difference file mode case. firebird upstream attempt as: FirebirdSQL/firebird#9089 And do it manually for the system-firebird case. Change-Id: Iff9ebbb075379ca47a7f7f5886b693ac23860566 Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/6702 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CPCI <releng@collaboraoffice.com> (cherry picked from commit e7ea381e87cadaf31bf1ad2213a23f17a6284d1c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208040 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208064 Tested-by: Jenkins
tdf-gerrit
pushed a commit
to LibreOffice/core
that referenced
this pull request
Jul 14, 2026
A database we extract from a .odb is always in the normal backup state, so refuse one that is not, we're not interested in the difference file mode case. firebird upstream attempt as: FirebirdSQL/firebird#9089 And do it manually for the system-firebird case. Change-Id: Iff9ebbb075379ca47a7f7f5886b693ac23860566 Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/6702 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CPCI <releng@collaboraoffice.com> (cherry picked from commit e7ea381e87cadaf31bf1ad2213a23f17a6284d1c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208040 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208064 Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208076
Member
|
On 7/14/26 01:48, Caolán McNamara wrote:
*caolanm* left a comment (FirebirdSQL/firebird#9089)
<#9089 (comment)>
LibreOffice, optionally, supports embedded firebird databases so we'd
like to not allow arbitrary dbs, that a user might receive from
someone else, to specify what file paths they backup to and the
LibreOffice firebird save
is via the backup mechanism.
Wider look at the problem is needed here. Yes, for embedded case this
seems to be useful, but take into an account large dedicated server.
From performance POV difference file should better be saved on separate
HW device which will sooner of all be mounted at some other location. As
the first sample this may be /tmp - which is hardly included into
DatabaseAccess.
I agree with your requirements for LibreOffice but suppose we need
something smarter.
|
Member
LibreOffice might issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The difference file opened in openDelta and beginBackup is not verified against DatabaseAccess, unlike the other database file paths. This looks like an oversight, presumably the setting is meant to cover every file the engine opens by path. Found while using the embedded engine from LibreOffice.