Feature #8974 - Declared Local Temporary Tables in Packages#8983
Open
asfernandes wants to merge 4 commits intomasterfrom
Open
Feature #8974 - Declared Local Temporary Tables in Packages#8983asfernandes wants to merge 4 commits intomasterfrom
asfernandes wants to merge 4 commits intomasterfrom
Conversation
asfernandes
force-pushed
the
work/packaged-ltt
branch
from
f565c41 to
bcf1e7a
Compare
Noremos
reviewed
Apr 8, 2026
| } | ||
|
|
||
| if (relationName.package.isEmpty()) | ||
| { // FIXME: indent |
Contributor
There was a problem hiding this comment.
Forgot to correct? Or is this a reminder for the future?
Member
Author
There was a problem hiding this comment.
It's to be corrected just before the merge or after it.
The indentation makes review difficult.
| return State::unknown; | ||
| } | ||
| #endif //DEV_BUILD | ||
|
|
Contributor
There was a problem hiding this comment.
Why remove the last blank line here and elsewhere?
Member
Author
There was a problem hiding this comment.
Because there were two empty lines.
Contributor
There was a problem hiding this comment.
Got it. Looks like GitHub isn't displaying the last blank line.
AlexPeshkoff
reviewed
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.