app decomposition, package moves, and ripple effect tuning#67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch is the full
feat/app-decompositionstack, not just the final Ripple Effect follow-up. It reorganizes built-in package layout, decomposes more of the Bubble Tea app shell into screen-local models, and updates Ripple Effect generation/tests.Diff Overview
app/,registry/,gameentry/, andgames/rippleeffect/What Changed
1. Package layout cleanup
games/*export/*app,cmd,registry, tests, and adapters to match the new package mapExamples:
fillomino->games/fillominorippleeffect->games/rippleeffectpdfexport->export/pdfpackexport->export/packbuiltinprint->export/builtinprint2. App/screen decomposition
Primary files:
app/export.goapp/model.goapp/screen_core.goapp/screen_navigation.goapp/update.goapp/view.go3. Registry/runtime wiring
games/*package locationscatalog,registry, andgameentryresponsibilities aligned with the repo package mapPrimary files:
registry/registry.gogameentry/gameentry.goarchitecture_test.go4. Ripple Effect difficulty and generator work
games/rippleeffectchanges beyond a pure renameMode.MaxCagePrimary files:
games/rippleeffect/gamemode.gogames/rippleeffect/generator.gogames/rippleeffect/rippleeffect_test.gogames/rippleeffect/README.mdWhy
games,export,registry,gameentry)Validation
just fmtjust lintjust test