Fix #389: reject the wrong embedded type for ZoneId, Period, and ZoneOffset - #392
Closed
adityabagla7 wants to merge 2 commits into
Closed
adityabagla7 wants to merge 2 commits into
adityabagla7 wants to merge 2 commits into
Conversation
… and ZoneOffset. A byte array was being stored as those values. Only a matching type is accepted now. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Ah. Looks like there is already #391; since it was submitted earlier, I think I will take that, closing this one. Thank you @adityabagla7 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A binary value was being stored as a ZoneId, Period, or ZoneOffset when it came in as an embedded object. A map of those types would then hold a byte array and not fail.
The deserializer now accepts an embedded value only when it is null or already the right type. Anything else fails with a mapping error. A real embedded ZoneId still works.
Tests are in
JSR310EmbeddedObjectDeserTest. They passed locally.Made with Cursor
Fixes #389