Skip to content

chore: remove undocumented cloud auth + event relay (pre-redesign) #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NiveditJain merged 2 commits into from
May 22, 2026
Merged

chore: remove undocumented cloud auth + event relay (pre-redesign) #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01663ed
chore: remove undocumented cloud auth + event relay subsystem
NiveditJain May 22, 2026
4421e6d
docs: changelog entry for the cloud auth/relay removal
NiveditJain May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 0.0.11-beta.2 — 2026-05-21

### Breaking
- Remove the undocumented cloud auth + event relay subsystem ahead of a from-scratch redesign. Deletes `src/auth/` (OAuth 2.0 device-flow login against `api.befailproof.ai`, `~/.failproofai/auth.json` token store) and `src/relay/` (WebSocket event relay daemon, sanitized JSONL queue at `~/.failproofai/cache/server-queue/`, PID tracking). Strips the `failproofai login` / `logout` / `whoami` / `relay start|stop|status` / `sync` subcommands and the internal `--relay-daemon` mode from `bin/failproofai.mjs`, along with their `--help` entries and "did you mean" suggestions. Removes the fire-and-forget `appendToServerQueue` + `ensureRelayRunning` calls from `src/hooks/handler.ts` so hook evaluation no longer enqueues events or lazy-spawns a daemon. The whole subsystem had zero references in `README.md`, `docs/`, `examples/`, or `__tests__/`, and only had internal cross-imports — `tsc`, `eslint`, `vitest` (1623 tests), and the `bun run build` bundles all stay green. Users who ran `failproofai login` should also wipe `~/.failproofai/{auth.json,cache/server-queue,relay.pid}` and stop any running relay daemon by hand; new auth/cloud surface will land in a follow-up.
Comment on lines +5 to +6
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use an allowed changelog subsection and include the PR-number suffix.

This entry uses ### Breaking and omits the PR-number ending; the repo rule requires Features|Fixes|Docs|Dependencies and a one-line entry with PR number.

Suggested patch 
-### Breaking
-- Remove the undocumented cloud auth + event relay subsystem ahead of a from-scratch redesign. Deletes `src/auth/` (OAuth 2.0 device-flow login against `api.befailproof.ai`, `~/.failproofai/auth.json` token store) and `src/relay/` (WebSocket event relay daemon, sanitized JSONL queue at `~/.failproofai/cache/server-queue/`, PID tracking). Strips the `failproofai login` / `logout` / `whoami` / `relay start|stop|status` / `sync` subcommands and the internal `--relay-daemon` mode from `bin/failproofai.mjs`, along with their `--help` entries and "did you mean" suggestions. Removes the fire-and-forget `appendToServerQueue` + `ensureRelayRunning` calls from `src/hooks/handler.ts` so hook evaluation no longer enqueues events or lazy-spawns a daemon. The whole subsystem had zero references in `README.md`, `docs/`, `examples/`, or `__tests__/`, and only had internal cross-imports — `tsc`, `eslint`, `vitest` (1623 tests), and the `bun run build` bundles all stay green. Users who ran `failproofai login` should also wipe `~/.failproofai/{auth.json,cache/server-queue,relay.pid}` and stop any running relay daemon by hand; new auth/cloud surface will land in a follow-up.
+### Fixes
+- Remove undocumented cloud auth/event relay surface (`src/auth/`, `src/relay/`), remove related CLI commands (`login/logout/whoami/relay/sync` and `--relay-daemon`), and stop hook relay enqueue/spawn calls in `src/hooks/handler.ts` (`#374`).

As per coding guidelines, CHANGELOG.md entries must use Features, Fixes, Docs, or Dependencies, and each entry should be one line with description and PR number.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHANGELOG.md` around lines 5 - 6, Replace the multi-line "### Breaking" entry
with a single-line entry under one of the allowed headings (Features, Fixes,
Docs, or Dependencies) and append the PR number suffix; locate the block that
begins with "### Breaking" and condense its content to a one-line summary
(removing the long file/token/daemon details) and add the PR reference like
"(`#PR_NUMBER`)". Ensure the header is changed to an allowed subsection (e.g.,
"### Features") and the entry is one concise sentence followed by the PR-number
suffix.


## 0.0.11-beta.1 — 2026-05-20

### Breaking
Expand Down
91 changes: 2 additions & 89 deletions bin/failproofai.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,28 +74,14 @@ if (hookIdx >= 0) {
}
}

// --relay-daemon — internal: long-running background process started by
// ensureRelayRunning(). Streams queued events to the server via WebSocket.
if (args.includes("--relay-daemon")) {
try {
const { runDaemon } = await import("../src/relay/daemon");
await runDaemon();
process.exit(0);
} catch (err) {
const msg = err instanceof Error ? err.message : String(err);
console.error(`Relay daemon error: ${msg}`);
process.exit(1);
}
}

/**
* Centralised error handler for all CLI subcommands.
* CliError → clean message, no stack trace, exit exitCode (1 or 2)
* Error → unexpected; shows message only, exits 2
*/
async function runCli() {
// --help / -h (only when not inside a subcommand that handles its own --help)
const SUBCOMMANDS = ["policies", "login", "logout", "whoami", "relay", "sync"];
const SUBCOMMANDS = ["policies"];
if ((args.includes("--help") || args.includes("-h")) && !SUBCOMMANDS.includes(args[0])) {
const extraArgs = args.filter((a) => a !== "--help" && a !== "-h");
if (extraArgs.length > 0) {
Expand Down Expand Up @@ -132,12 +118,6 @@ COMMANDS

policies --help, -h Show this help for the policies command

login Authenticate with the failproofai cloud (Google OAuth)
logout Clear local auth tokens and stop relay daemon
whoami Print current logged-in user
relay start|stop|status Manage the event relay daemon
sync One-shot flush of pending events to the server

--version, -v Print version and exit
--help, -h Show this help message

Expand Down Expand Up @@ -429,73 +409,6 @@ EXAMPLES
process.exit(0);
}

// login — authenticate with failproofai server via Google OAuth
if (args[0] === "login") {
const { login } = await import("../src/auth/login");
await login();
process.exit(0);
}

// logout — clear local tokens and stop relay daemon
if (args[0] === "logout") {
const { logout } = await import("../src/auth/logout");
await logout();
process.exit(0);
}

// whoami — print current user and auth status
if (args[0] === "whoami") {
const { whoami } = await import("../src/auth/logout");
whoami();
process.exit(0);
}

// relay start|stop|status — manage the event relay daemon
if (args[0] === "relay") {
const subcmd = args[1];
const { relayStatus, stopRelay } = await import("../src/relay/pid");

if (subcmd === "status") {
const s = relayStatus();
if (s.running) console.log(`Relay daemon running (pid ${s.pid})`);
else if (s.pid !== null) console.log(`Stale PID file (${s.pid}); daemon not running`);
else console.log("Relay daemon not running");
process.exit(0);
}

if (subcmd === "stop") {
const stopped = stopRelay();
console.log(stopped ? "Relay daemon stopped" : "Relay daemon was not running");
process.exit(0);
}

if (subcmd === "start") {
const { ensureRelayRunning, waitForRelayAlive } = await import("../src/relay/daemon");
ensureRelayRunning();
// Spawn is async — give the child a moment to write its PID file
const alive = await waitForRelayAlive();
const s = relayStatus();
if (alive && s.running) {
console.log(`Relay daemon started (pid ${s.pid})`);
process.exit(0);
}
console.log("Failed to start daemon");
process.exit(1);
}

throw new CliError(
`Usage: failproofai relay <start|stop|status>`
);
}

// sync — one-shot flush of pending events to server (fallback for no daemon)
if (args[0] === "sync") {
const { runOneShotSync } = await import("../src/relay/daemon");
const count = await runOneShotSync();
console.log(`Synced ${count} event${count === 1 ? "" : "s"} to server`);
process.exit(0);
}

// Unknown flag guard — must appear after all known-flag branches
const knownFlags = ["--version", "-v", "--help", "-h", "--hook"];
const unknownFlag = args.find(a => a.startsWith("-") && !knownFlags.includes(a));
Expand All @@ -514,7 +427,7 @@ EXAMPLES
return dp[m][n];
}

const primary = ["--version", "--help", "--hook", "policies", "login", "logout", "whoami", "relay", "sync"];
const primary = ["--version", "--help", "--hook", "policies"];
const closest = primary.reduce((best, flag) => {
const dist = levenshtein(unknownFlag, flag);
return dist < best.dist ? { flag, dist } : best;
Expand Down
104 changes: 0 additions & 104 deletions src/auth/login.ts
View file
Open in desktop

This file was deleted.

50 changes: 0 additions & 50 deletions src/auth/logout.ts
View file
Open in desktop

This file was deleted.

64 changes: 0 additions & 64 deletions src/auth/token-store.ts
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions src/hooks/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,25 +340,6 @@ export async function handleHookEvent(
hookLogWarn("activity persistence failed");
}

// Enqueue for server relay — fire-and-forget, never blocks hook.
// queue.ts is a no-op if the user is not logged in (no auth.json), and
// sanitizes the entry before persisting (drops toolInput/transcriptPath,
// hashes cwd, redacts known secret patterns in `reason`).
try {
const { appendToServerQueue } = await import("../relay/queue");
appendToServerQueue(activityEntry);
} catch {
// Server queue is best-effort; fail-open
}

// Lazy-start relay daemon if user is logged in — ~1ms when already running
try {
const { ensureRelayRunning } = await import("../relay/daemon");
ensureRelayRunning();
} catch {
// Relay is best-effort; hook must succeed regardless
}

// Fire PostHog telemetry for decisions that affect Claude's behavior
if (result.decision === "deny" || result.decision === "instruct") {
try {
Expand Down
Loading