fix(module-ci): report raptor's real outcome per output type - #18
Merged
Merged
Conversation
The PR comment restated the flag rather than the result, so every row read "created if absent" — including the rows that were skipped because the type already exists. That is precisely the question the comment exists to answer: which definitions does this pull request create, and which already exist and will therefore change when it merges? A per-file constant cannot answer it. Found on a live run against a real modules repository: four rows, one genuinely created and three untouched, all four labelled identically. The step now captures raptor's own output and takes the outcome from it, adds the resolved @namespace/name, and carries the compatibility findings into a "Reported changes" column. A row that says "skipped (already exists)" with findings is the one a reviewer has to look at — those changes land on merge. Findings have "|" escaped so a finding cannot split the table cell. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Found on a live run against a real modules repository (vibe-modules #5): four output type definitions, one genuinely created and three untouched, and the PR comment labelled all four identically:
outputs/citest/ci_probe.yamloutputs/custom/gcp_folder.yamloutputs/custom/gcp_org_account.yamloutputs/custom/gcp_project.yamlThe step restated the flag instead of the result. That is precisely the question the comment exists to answer: which definitions does this pull request create, and which already exist and will therefore change when it merges? A per-file constant cannot answer it.
After
The step captures raptor's own output and takes the outcome from it, adds the resolved
@namespace/name, and carries the compatibility findings into aReported changescolumn — verified on the same repository:outputs/citest/ci_probe.yaml@citest/ci_probeoutputs/custom/gcp_folder.yaml@custom/gcp_folderoutputs/custom/gcp_org_account.yaml@custom/gcp_org_accountoutputs/custom/gcp_project.yaml@custom/gcp_projectA row that says
skipped (already exists)with findings is the one a reviewer has to look at: those changes land on merge.Findings have
|escaped so a finding cannot split the table cell.Testing
Verified end to end on
Facets-cloud/vibe-modulesagainst its real control plane, with the action pinned to this branch's commit. The control plane was checked afterwards and confirmed unchanged — norequiredkey and no added field — so the reported change really was reported and not written.bash -nandshellcheck --severity=warningclean.Scope is inside the
Apply output typesstep only, which is skipped entirely when a repository has nooutputs/tree.🤖 Generated with Claude Code